New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768805 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Accelerators such as alt-+ to maximize don't work for simple wayland clients

Project Member Reported by reve...@chromium.org, Sep 26 2017

Issue description

wayland clients need to create a keyboard instace for accelerators to work. This should not be needed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91655e60b5e62d94a241c057a0c7aa36b823f3ef

commit 91655e60b5e62d94a241c057a0c7aa36b823f3ef
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Thu Sep 28 07:13:19 2017

Switch to use pre-target handler in exo::Keyboard.

This is a refactoring change to let ShellSurfaceWidget::OnKeyEvent
process all key events.
This change should make standard chrome key bindings work for simple
wayland test clients that are not creating a exo::Keyboard instance.

Bug:  768805 
Test: No behavior change. Tests pass.
Change-Id: Ia8926de9a56f0f6efc2ff01e19eb53602cbbff0b
Reviewed-on: https://chromium-review.googlesource.com/684004
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504930}
[modify] https://crrev.com/91655e60b5e62d94a241c057a0c7aa36b823f3ef/components/exo/keyboard.cc
[modify] https://crrev.com/91655e60b5e62d94a241c057a0c7aa36b823f3ef/components/exo/keyboard.h
[modify] https://crrev.com/91655e60b5e62d94a241c057a0c7aa36b823f3ef/components/exo/shell_surface.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69b942d2eb876e2865ce4b8556b53425aceff4b9

commit 69b942d2eb876e2865ce4b8556b53425aceff4b9
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Fri Sep 29 03:10:27 2017

Remove unused struct definition.

TBR=reveman@chromium.org

Bug:  768805 
Test: Tests pass.
Change-Id: I95e40b2d43c6ee0d670924214712a1960d6e7f38
Reviewed-on: https://chromium-review.googlesource.com/691534
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505271}
[modify] https://crrev.com/69b942d2eb876e2865ce4b8556b53425aceff4b9/components/exo/keyboard.cc

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment