The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc

commit cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Oct 10 11:33:44 2017

Implement password selection and viewing on Mac.

The CL changes the layout of the password bubble on Mac according to the mocks.
The password selection combobox and eye icon are now fully functional.

Bug:  769666 ,753806, 768781 
Change-Id: Iac6f6186f07bad3da2e5f66407ddc782b61f1842
Reviewed-on: https://chromium-review.googlesource.com/708261
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507639}
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/password_item_views.h
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.mm
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.h
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm

This is how the layout will look like in RTL when the Mac RTL is enabled by default.

Deleted: Screen Shot 2017-10-13 at 17.39.54.png 21.0 KB

	Screen Shot 2017-10-13 at 17.39.54.png 21.0 KB View Download

Deleted: Screen Shot 2017-10-13 at 17.40.07.png 21.2 KB

	Screen Shot 2017-10-13 at 17.40.07.png 21.2 KB View Download

The buttons are on the wrong side for RTL (should be on the left)?

Yeah, that's true. But the feature is off for now, so it's not critical.

That's fine - just making sure you know.

Reopening so that the needed RTL fix doesn't get forgotten. It was a P1 but you're saying it's not critical - I will leave it to you to prioritize.

The bug is fixed with launching Mac Views.

Deleted: Screenshot from 2018-02-12 15-32-41.png 14.6 KB

	Screenshot from 2018-02-12 15-32-41.png 14.6 KB View Download