Do we really need //tools/perf/chrome_telemetry_build/chromium_config.py ? |
|||||
Issue descriptionHi Ned, This config [1] https://cs.chromium.org/chromium/src/tools/perf/chrome_telemetry_build/chromium_config.py looks as a hack to configure Telemetry. Can we achieve the same effect using Telemetry public API or by making it? Also it was unobvious that //tools/perf/run_benchmark and folks can override default behavoiur of Telemetry. [2] https://crbug.com/768334 I think it would be better to avoid and prevent overriding configuration which is not intended to be configurable. Thanks!
,
Sep 26 2017
Ah ok, it makes sense since Telemetry is agnostic to Chromium location. It's alright to inherit ChromiumConfig from ProjectConfig. Thing still concerns me is that we pass a path to json in unspecified format. Better if ProjectConfig will provide methods like set_flash_plugin_path(), etc. It will exlicitly specify which features can be configured and which can't. It's not time critical anyway.
,
Sep 26 2017
I share your concern that none of the binaries set in the json file seems to be related to the code that use them in an obvious way. I will leave this bug around for backlog purpose.
,
Sep 26 2017
Thanks!
,
Aug 1
,
Jan 16
,
Jan 16
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nedngu...@google.com
, Sep 26 2017