New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768751 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Text wrapping is not proper for Auto-Fill Settings text after changing browser language to French.

Reported by aiman.an...@etouch.net, Sep 26 2017

Issue description

Chrome Version: 63.0.3223.8 (Official Build)47de836373a20038efd14f8c3a154326f8c9ddda-refs/branch-heads/3223@{#11} (64-bit)

OS: Windows(7,8,10).

Steps to reproduce:
1.Launch Chrome, go to chrome://settings, change browser language to 'French' from chrome://settings/languages.
2.Relaunch chrome, go to chrome://settings/appearacne and change Font Size to 'Very Large' .
3.Go to chrome://settings/passwordsAndForms, observe text for Auto-fill Settings.

Actual Result: Text wrapping is not proper for Auto-Fill Settings text after changing browser language to French. 
Expected Result: Text wrapping should be proper for Auto-Fill Settings text after changing browser language to French.  

This is regression issue broken in ‘M-63’ and below per-revision bisect result

Using the per-revision bisect providing the bisect results,
Good Build: 63.0.3215.0 (Revision: 501822)
Bad Build: 63.0.3216.0 (Revision: 502108)

You are probably looking for a change made after 501851 (known good), but no later than  501852 (first known bad).

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/2700afca42099e3af0c2eed7a1fef7f1559c55d3..49684282e5a1536d55af2ba4934931eaf6c59272

Suspect: https://chromium.googlesource.com/chromium/src/+/49684282e5a1536d55af2ba4934931eaf6c59272

@dschuyler: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!

 
Actual Result.png
61.6 KB View Download
Expected Result.png
73.2 KB View Download
Note: The above issue is not seen on Mac and Linux OS
Labels: Proj-MaterialDesign-WebUI
Please help me understand the issue:

I *think* the issue is that "clic" on the second line is centered and it should be on the far left (aka "start"). I'll fix the alignment.

Though is "simple clic" intended to have a non-breaking space? (I'm aware that some two word combinations need to be kept together in French, but I don't know if this is one of those cases). If this is needed, please add a bug (to go to the translation folks) to connect these words.


Status: Started (was: Assigned)
CL at https://chromium-review.googlesource.com/c/chromium/src/+/685536
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4b953bcbafe41b3baaa9fc1a1fdd4ab708e1471

commit e4b953bcbafe41b3baaa9fc1a1fdd4ab708e1471
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue Sep 26 22:16:35 2017

[cr webui] cr-link-row align text to start

This CL is a CSS only change that aligns text labels in cr-link-row
elements to the start (rather than centering the text).

Bug:  768751 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6d95194f8b14bb4da559ab7f095b2efcc21af0b3
Reviewed-on: https://chromium-review.googlesource.com/685536
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504498}
[modify] https://crrev.com/e4b953bcbafe41b3baaa9fc1a1fdd4ab708e1471/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html

Status: Fixed (was: Started)
Labels: TE-Verified-63.0.3225.0 TE-Verified
Note:
Retested the above issue on Win(7,8,10) for latest Canary #63.0.3225.0 and fix is working as intended.
Current_Result.png
148 KB View Download
Labels: -TE-Verified TE-Verified-M63

Sign in to add a comment