Not enough cats in the system tray |
||
Issue descriptionThe Chrome OS system tray can display the small icon of notifications that are waiting for the user. This is analogous to the status bar on Android devices. Web Developers can indicate the small icon of their notifications through the `badge` property. We support this for Android. Just on Android. https://notifications.spec.whatwg.org/#badge-resource Because of this, Web Notifications shown on Chrome OS use the default icon at most. Since they're now visible on the toast as well, let's just remove the Android-only restriction. Test this at: https://tests.peter.sh/notification-generator/ When fixed, the notification and the system tray icon should have a cat with the appropriate accent colour.
,
Sep 26 2017
,
Sep 26 2017
The intention was to follow android guideline for notification. Meaning that the right-hand icon would not be provided anymore unless absolutely helping the content (image preview or contact picture). We page would supply a monochrome version (automatically painted if not) for the icon in the header. Unless the web page supplies the icon, just like on Android, I cannot recommend we automatically paint over an icon not designed for that. In term of color, I thought about enabling customization but it's another can of worm I don't want to open right now (mostly accessibility concerns and the need to build around that).
,
Sep 26 2017
> Unless the web page supplies the icon, just like on Android, I cannot recommend we automatically paint over an icon not designed for that. This is for icons specifically provided by the website. We already support this on Android, so I think of this as aligning the platforms. > In term of color, I thought about enabling customization but it's another can of worm I don't want to open right now (mostly accessibility concerns and the need to build around that). Yes, I briefly mentioned accessibility as the blocking concern for exposing that functionality in a meeting with the Tokyo team yesterday. However, we *do* already have Chrome UI approval for this. Android ensures that there is sufficient contrast natively, so if we were to have a similar mechanism for the message center there won't be any further blockers. Nonetheless, that's another issue - for the icon we just have to make sure that it does the right thing whatever colour is decided upon, which, for now, will be the default color when dealing with Web Notifications.
,
Sep 26 2017
> Nonetheless, that's another issue - for the icon we just have to make sure that it does the right thing whatever colour is decided upon, which, for now, will be the default color when dealing with Web Notifications. That means painting whatever they give us right ? Just like you showed in your example? Sent a message off thread to update badges and requirements.
,
Sep 26 2017
>> That means painting whatever they give us right ? Just like you showed in your example? Yes, but masked with the default accent colour for small icons. Right now that is defined to be the Chrome icon grey, i.e. 0x5A5A5A.
,
Sep 26 2017
Got it that makes sense.
,
Sep 28
Issue 889616 has been merged into this issue.
,
Sep 28
Hey folks, is there any update here with regards to whether crrev/684454 should land?
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e4c40b8d74dea914e484c3ae77af4db67b66666 commit 5e4c40b8d74dea914e484c3ae77af4db67b66666 Author: Richard Knoll <knollr@chromium.org> Date: Wed Dec 19 16:15:22 2018 feat: enable badge icons for non-android platforms This enables the use of badge icons for new style notifications, on platforms other than Android. Largely based on https://crrev.com/c/684454 Bug: 768748 Change-Id: I1935963ce2fda8b913079857714416fcfc726d1a Reviewed-on: https://chromium-review.googlesource.com/c/1318977 Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#617847} [modify] https://crrev.com/5e4c40b8d74dea914e484c3ae77af4db67b66666/chrome/browser/notifications/platform_notification_service_impl.cc [modify] https://crrev.com/5e4c40b8d74dea914e484c3ae77af4db67b66666/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc [modify] https://crrev.com/5e4c40b8d74dea914e484c3ae77af4db67b66666/ui/message_center/views/notification_view_md.cc |
||
►
Sign in to add a comment |
||
Comment 1 by peter@chromium.org
, Sep 26 2017