New issue
Advanced search Search tips

Issue 768737 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Files app: Tapping an open item does not respond sometimes.

Project Member Reported by fukino@chromium.org, Sep 26 2017

Issue description

Chrome Version: 61.0.3163.87
OS: Chrome

What steps will reproduce the problem?
(1) Open Files app
(2) Select a file which has two or more open items.
(3) Tap "OPEN" dropdown menu on the toolbar.
(4) Tap an app in the dropdown menu. The app will open.
(5) Tap "OPEN" dropdown menu again.
(6) Tap the same app as step #4.

What is the expected result?
The same app should open or be activated.

What happens instead?
Nothing happens.

This is a public issue of b/65589407 with a repro steps which is not specific to ARC.
This issue reproduces only when we select the app by touch or stylus.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d561a9f46130f9e2740ce4acdba45bb345753560

commit d561a9f46130f9e2740ce4acdba45bb345753560
Author: Naoki Fukino <fukino@chromium.org>
Date: Wed Sep 27 02:19:19 2017

Clear selectedItem property when menu items are cleared.

Keeping selectedIndex/selectedItem on clear can cause an issue in this scenario:
1) Tap the 1st menu item. selectedIndex is now 0.
2) Menu items are cleared. selectedIndex property is still 0.
3) New menu items are created in the menu.
4) Tap the 1st menu item again. As the selectedIndex is not changed,
selectedIndexChange event will not be dispatched.
5) menu's selectedIndecChanged function will not called, so the 1st item's
selected property remains false.
6) 'mouseup' event on the menu item will be ignored, since its selected property
is false.

This can be fixed by clearing selectedItem/selectedIndex when menu items are
cleared.

Bug:  768737 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2a99b3882b3917f4fc63ca8b16e108a4538c4cac
Reviewed-on: https://chromium-review.googlesource.com/684101
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504550}
[modify] https://crrev.com/d561a9f46130f9e2740ce4acdba45bb345753560/ui/webui/resources/js/cr/ui/menu.js

Comment 2 by fukino@chromium.org, Sep 27 2017

Labels: Merge-Request-62
Labels: -Merge-Request-62 Merge-Approved-62
Approved for 62, but please verify a Chrome with this change makes it through the PFQ before merging back. 
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 2 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8094c663a6d7ce51a03ad90a6b72b5b92336a471

commit 8094c663a6d7ce51a03ad90a6b72b5b92336a471
Author: Naoki Fukino <fukino@chromium.org>
Date: Mon Oct 02 03:35:42 2017

Clear selectedItem property when menu items are cleared.

Keeping selectedIndex/selectedItem on clear can cause an issue in this scenario:
1) Tap the 1st menu item. selectedIndex is now 0.
2) Menu items are cleared. selectedIndex property is still 0.
3) New menu items are created in the menu.
4) Tap the 1st menu item again. As the selectedIndex is not changed,
selectedIndexChange event will not be dispatched.
5) menu's selectedIndecChanged function will not called, so the 1st item's
selected property remains false.
6) 'mouseup' event on the menu item will be ignored, since its selected property
is false.

This can be fixed by clearing selectedItem/selectedIndex when menu items are
cleared.

Bug:  768737 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2a99b3882b3917f4fc63ca8b16e108a4538c4cac
Reviewed-on: https://chromium-review.googlesource.com/684101
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504550}(cherry picked from commit d561a9f46130f9e2740ce4acdba45bb345753560)
Reviewed-on: https://chromium-review.googlesource.com/694761
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#531}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/8094c663a6d7ce51a03ad90a6b72b5b92336a471/ui/webui/resources/js/cr/ui/menu.js

Status: Fixed (was: Started)
Labels: -M-61 M-62

Sign in to add a comment