New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768734 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 726246



Sign in to add a comment

Remove notifier group support in NotifierSettingsView

Project Member Reported by tetsui@chromium.org, Sep 26 2017

Issue description

https://cs.chromium.org/chromium/src/ash/message_center/notifier_settings_view.cc?l=509&rcl=da85874e0ca9635522b92bdb13efe57947c1a317
> There's only ever one notifier group in ash.

Because there are some amount of code in NotifierSettingsView to support that, we have to remove them first in order to implement https://crbug.com/726246
 

Comment 1 by tetsui@chromium.org, Sep 26 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96a64820e897c7fcf98f80ed8f54bb76789bd975

commit 96a64820e897c7fcf98f80ed8f54bb76789bd975
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Thu Sep 28 02:45:50 2017

Remove notification group support in NotifierSettingsView.

There's always only one notifier group in ash. As NotifierSettingsView
is moved to ash/, we can safely remove notifier group support.

TEST=ash_unittests
BUG= 768734 

Change-Id: I1b018cf25c31e8549922e25f83f341bd26542ec8
Reviewed-on: https://chromium-review.googlesource.com/684099
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504876}
[modify] https://crrev.com/96a64820e897c7fcf98f80ed8f54bb76789bd975/ash/message_center/notifier_settings_view.cc
[modify] https://crrev.com/96a64820e897c7fcf98f80ed8f54bb76789bd975/ash/message_center/notifier_settings_view.h

Comment 3 by tetsui@chromium.org, Sep 28 2017

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment