New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768723 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove build_overrides/webrtc.gni

Project Member Reported by kjellander@chromium.org, Sep 26 2017

Issue description

Setting Chromium/WebRTC specific defaults for GN variables is now supposed to be in the .gn file, so we should get rid of build_overrides/webrtc.gni since it's no longer used (and just causing confusion).
 
Similar for V8 is  bug 684096 .
Cc: mbonadei@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa9d1da9798138d57d684776f2dc2cbf3637b653

commit aa9d1da9798138d57d684776f2dc2cbf3637b653
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Tue Sep 26 11:17:16 2017

Remove build_overrides/webrtc.gni

It's no longer used and the same functionality can be accomplished
by adding variable defaults to the .gn default_args dict.

Bug:  768723 
Change-Id: I5f6723c2831fb0a5c9eba24ba53b3152ed3c8352
Reviewed-on: https://chromium-review.googlesource.com/684175
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504336}
[delete] https://crrev.com/f2527f08d32aa5f9f13d37bdac85b416199fde61/build_overrides/webrtc.gni

Status: Fixed (was: Assigned)
Closing as the file was already gone from the webrtc repo.

Sign in to add a comment