New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768717 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessarily focus appears on arrow icon after clicking on 'Customize fonts' row.

Reported by avsha...@etouch.net, Sep 26 2017

Issue description

Chrome version : 63.0.3223.8 (Official Build) 47de836373a20038efd14f8c3a154326f8c9ddda-refs/branch-heads/3223@{#11} 32/64 bit
OS : Windows (7,8,10), Linux(14.04 LTS), Mac(10.12.6)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://settings page.
2. In 'Appearance' section, click & hold on 'Customize fonts' row.
3. Observe the arrow icon.

Actual Result : Unnecessarily focus appears on arrow icon after clicking on 'Customize fonts' row.

Expected Result : Instead, a focus should not appear on arrow icon when clicking on 'Customize fonts' row and focus should appear on arrow icon only when user directly clicks on an arrow icon.

(Note : This focus issue is observed only for 'Customize fonts' and 'Autofill settings' rows).

This is a regression issue broken in ‘M-63’ and using the per-revision bisect providing the bisect results,
Good build : 63.0.3221.0 (Revision : 503309)
Bad build : 63.0.3222.0 (Revision : 503582)

You are probably looking for a change made after 503562 (known good), but no later than 503564 (first known bad).

CHANGELOG URL: 
https://chromium.googlesource.com/chromium/src/+log/35a70dafa6aae5e636bc241a276d53c3d5b1291d..2f873e14c7ef408a7c55697b8e166bb46e3bfdcd

Suspect : https://chromium.googlesource.com/chromium/src/+/19192ca1fb559b64de7ccf679ab584f66f86a450

@dschuyler : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank you!
 
Actual_Result.mp4
1.6 MB View Download
Expected_Result.mp4
1.0 MB View Download
Cc: scottchen@chromium.org tbuck...@chromium.org
Owner: bettes@chromium.org
Alan, I'd like your thoughts on what to ripple when a row is clicked. This isn't a technical issue, it just needs a UX call on what is desired.

I think it'll be easiest to send me a chat when you want to talk about it.

Choices include:
A) go with the Actual_Result.mp4 where the icon ripples even when the label is clicked
B) go back to Expected_Result.mp4 where there is no ripple (at all) for a click on the label
C) change to making a ripple where the click happens (center on point of click)
D) something else (this list could be long if all possibilities were mentioned)

Trivia: I think (C) is a solid option, that'd be my pick.

Comment 2 by bettes@chromium.org, Oct 23 2017

Owner: dschuyler@chromium.org
Would option B state that a ripple happens when the click happens on the arrow (not the label)? 

If the answer is yes, then I'd lean towards option B. Certainly more so than option A (what we have today). However I recall us doing option A for a specific reason that is escaping me now. 

Option C is also interesting, but I'm curious how these ripples would behave for rows with double actions. Would the ripple be contained in left or right quadrants of the row? Ideally so, but is that sorta thing an expansion in scope? 

 
Labels: -Pri-1 -M-63 M-65 Pri-3
Thanks for the bug report. There is an issue here. We talked about it in UX meeting today and decided to make this low priority or WontFix because we're on the verge of changing the ripple/focus behavior. If that doesn't happen by m-65 then this should be revisited. Marking this Pri-3, and moving the milestone to m-65 in the meantime.
Labels: OS-Chrome
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment