New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 768691 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Jan 2018
Cc:
█ trchen@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocking:
issue 771643



Sign in to add a comment

Mask clip fails fast/borders/inline-mask-overlay-image-outset-vertical-rl.html

Project Member Reported by wangxianzhu@chromium.org, Sep 26 2017 
If we enable mask clip on SPv1 (e.g. https://chromium-review.googlesource.com/c/chromium/src/+/667756/8), fast/borders/inline-mask-overlay-image-outset-vertical-rl.html will fail (https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/552159/layout-test-results/results.html).

It seems that the mask clip is incorrect in vertical-rl writing mode.

For now I disable mask clip on SPv1 in https://chromium-review.googlesource.com/c/chromium/src/+/667756.

Comment 1 by trchen@chromium.org, Jan 18 2018

Cc: wangxianzhu@chromium.org
Hey Xianzhu, do you know if the bug still applies?

I remember the RTL/flipping issue also affects the visual rects of drawings. If https://chromium-review.googlesource.com/c/chromium/src/+/868954 is not causing problems, it is possible that the RTL issue is already fixed by someone.

Comment 2 by wangxianzhu@chromium.org, Jan 18 2018 

The test still fails (as virtual/spv175/fast/borders/inline-mask-overlay-image-outset-vertical-rl.html).

Comment 3 by wangxianzhu@chromium.org, Jan 18 2018

Blocking: 771643

Comment 4 by wangxianzhu@chromium.org, Jan 18 2018

Status: WontFix (was: Assigned)
The current failure seems not vertical-rl specific because virtual/spv175/fast/borders/inline-mask-overlay-image.html and virtual/spv175/fast/borders/inline-mask-overlay-image-outset.html also fail. As these bugs are associated to  bug 771643 , let's close this one.

Comment 5 by wangxianzhu@chromium.org, Jan 23 2018

Cc: -wangxianzhu@chromium.org trchen@chromium.org
Owner: wangxianzhu@chromium.org
Status: Assigned (was: WontFix)
With virtual/spv175/fast/borders/inline-mask-overlay-image.html and and virtual/spv175/fast/borders/inline-mask-overlay-image-outset.html fixed, fast/borders/inline-mask-overlay-image-outset-vertical-rl.html still fails. Perhaps we just need a flip for mask clip.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa1132254d99bcf2170f03b8e2eecdc7c378be0d

commit aa1132254d99bcf2170f03b8e2eecdc7c378be0d
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Jan 26 17:55:01 2018

[SPv175+] Flip mask clip rect for inline object writing mode

Bug:  768691 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I46857805a46a44c9c3a2ce3280d7dbb3e32c0825
Reviewed-on: https://chromium-review.googlesource.com/882454
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531993}
[modify] https://crrev.com/aa1132254d99bcf2170f03b8e2eecdc7c378be0d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/aa1132254d99bcf2170f03b8e2eecdc7c378be0d/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Comment 7 by wangxianzhu@chromium.org, Jan 30 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment