New issue
Advanced search Search tips

Issue 768663 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Harmony ChromeOS: "EchoDialogView". Shown to redeem offers bundled with Chromebooks

Project Member Reported by tapted@chromium.org, Sep 26 2017

Issue description

Chrome Version       : 63ish
OS Version: 9765.63.0

To summon on a Chromebook,

visit http://www.google.com/intl/en/chrome/devices/goodies.html

and click through to redeem an offer (like play music, drive storage).

See also Issue 175070, which has a link to the original mocks.

// Dialog shown by echoPrivate extension API when getUserConsent function is
// called. The API is used by echo extension when an offer from a service is
// being redeemed. The dialog is shown to get an user consent. If the echo
// extension is not allowed by policy to redeem offers, the dialog informs user
// about this.

Attaching how it currently looks with --secondary-ui-md.

Tracking this here, since this may be the _only_ place in Chrome UI that uses underlined text outside of a hyperlink. This has implications for Harmony typography.

The mocks linked from Issue 175070 explain why it is underlined.

The dialog currently appears as a window-modal, not tab-modal. (or maybe system modal).
 
Screenshot 2017-09-26 at 11.51.47.png
847 KB View Download
Cc: hwi@chromium.org

Comment 2 by hwi@chromium.org, Sep 26 2017

Owner: bettes@chromium.org
Attaching a screen recording.

Also, here's a suggestion. 
bettes@, please review and advise. 

- Title: Check eligibility
- Body: Google Play Music (https://play.google.com) wants to check if your Chrome OS device is eligible for an offer.
- Underline & tooltip on 'Google Play Music': remove
- Learn more: remove or replace with (?) at the bottom left corner (currently the destination is a blank page).
- Buttons: [Check now] [Cancel]
- Modality: regular tab modal i.e. centered and attached to the bottom edge of the omnibox (currently it's window modal). 
- 'x': remove


Sep 26 2017 3_57 PM.webm
4.4 MB View Download

Comment 3 by bettes@chromium.org, Jan 11 2018

Cc: -hwi@chromium.org bettes@chromium.org
Owner: ----
Thank you Hwi. Suggestions LGTM. Opened up for triaging.
Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment