Test shouldInterceptRequest behavior for redirects |
||||||
Issue descriptionFollow-up from issue 702785 . We currently don't test shouldInterceptRequest behavior for redirects. Even worse, we don't actually document the correct behavior (should it be called for redirects or not?). We should investigate the correct behavior, consider documenting this in Android, and add integration tests. --- We might consider extending this to most of the WebView client callbacks. We have some examples in other javatests for creating redirects, but I'm not confident how good the code coverage really is.
,
Sep 26 2017
Also see issue 416782
,
Oct 20 2017
We should also check shouldOverrideUrlLoading's behavior, we got an email which says that behavior changed in M63.
,
Nov 15 2017
,
Nov 21 2017
Not actively looking at this, so I'm lowering the priority.
,
Jun 19 2018
,
Jun 19 2018
,
Jun 19 2018
Regarding comment #3, Looks like shouldOverrideUrlLoading has plenty of tests related to redirects. Not sure anymore which email I referred to.
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a024cbc4f69db4fbd2e7f419f9db1f6cc0ad4b22 commit a024cbc4f69db4fbd2e7f419f9db1f6cc0ad4b22 Author: Nate Fischer <ntfschr@chromium.org> Date: Tue Jun 19 19:27:45 2018 AW: add test for shouldInterceptRequest and redirects No change to production logic. This adds a test for shouldInterceptRequest with server-side redirects because this was previously untested. R=boliu@chromium.org Bug: 768631 Test: run_webview_instrumentation_test_apk -f AwContentsClientShouldInterceptRequestTest#testNotCalledForHttpRedirect Change-Id: I3eccada1e249269a4f66395a8d10a107001e1231 Reviewed-on: https://chromium-review.googlesource.com/1105630 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568565} [modify] https://crrev.com/a024cbc4f69db4fbd2e7f419f9db1f6cc0ad4b22/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java
,
Jun 19 2018
Just adds tests, mark as verified. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ntfschr@chromium.org
, Sep 26 2017