New issue
Advanced search Search tips

Issue 768630 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 763398
Owner: ----
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Mac debug (non-component) build fails verify_order step (again)

Project Member Reported by thestig@chromium.org, Sep 26 2017

Issue description

At r504235, build on Mac with:

is_component_build = false
is_debug = true

Expected: successful build
Actual: verify_order failure

../../chrome/tools/build/mac/verify_order: unordered symbols in Chromium Framework.framework/Versions/A/Chromium Framework:
__ZN7logging11CheckLTImplIZNK3net16HostResolverImpl8ProcTask27RecordPerformanceHistogramsERKN4base9TimeTicksEiiE8CategoryiEEPNSt3__112basic_stringIcNS9_11char_traitsIcEENS9_9allocatorIcEEEERKT_RKT0_PKc
__ZN7logging17MakeCheckOpStringIZNK3net16HostResolverImpl8ProcTask27RecordPerformanceHistogramsERKN4base9TimeTicksEiiE8CategoryiEEPNSt3__112basic_stringIcNS9_11char_traitsIcEENS9_9allocatorIcEEEERKT_RKT0_PKc
__ZN7logging22MakeCheckOpValueStringIZNK3net16HostResolverImpl8ProcTask27RecordPerformanceHistogramsERKN4base9TimeTicksEiiE8CategoryEENSt3__19enable_ifIXaasr4base8internal23SupportsOstreamOperatorIRKT_EE5valuentsr3std11is_functionINS9_14remove_pointerISB_E4typeEEE5valueEvE4typeEPNS9_13basic_ostreamIcNS9_11char_traitsIcEEEESD_

Traceback (most recent call last):
  File "../../chrome/tools/build/mac/run_verify_order.py", line 27, in <module>
    [ os.path.join(this_script_dir, 'verify_order') ] + unknown_args)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../../chrome/tools/build/mac/verify_order', '_ChromeMain', 'Chromium Framework.framework/Versions/A/Chromium Framework']' returned non-zero exit status 1


Questions for Mac folks: This has happened before for different reasons. Is this a P1 or P3? Why is there no bot to test this configuration? Too much work for too rare of a problem?
 

Comment 1 by rsesek@chromium.org, Sep 26 2017

Mergedinto: 763398
Status: Duplicate (was: Untriaged)
> Questions for Mac folks: This has happened before for different reasons. Is this a P1 or P3? Why is there no bot to test this configuration? Too much work for too rare of a problem?

Because we've basically decided to not care about static debug builds: 

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/kk47YfzT0vQ/TdkATNL_CAAJ
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/LWRR3fMlvQ4/5VZc1Zu1BgAJ
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e96c3116e28f97b03c4448120c8cb43a878ed173

commit e96c3116e28f97b03c4448120c8cb43a878ed173
Author: Mark Mentovai <mark@chromium.org>
Date: Tue Sep 26 17:40:55 2017

Fix macOS non-component debug build

This broke in 223326c134a0.

Bug:  763398 ,  768630 
Change-Id: Ie5e7eb7a7d3ea01a30b8a262db22931c2ed7d4d9
Reviewed-on: https://chromium-review.googlesource.com/684616
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504416}
[modify] https://crrev.com/e96c3116e28f97b03c4448120c8cb43a878ed173/net/dns/host_resolver_impl.cc

Thanks for the quick fix. Sadly I have an issue that requires a static build.

Comment 4 by mark@chromium.org, Sep 26 2017

Cc: mark@chromium.org
There’s nothing sad about static builds.

Sign in to add a comment