`cros tryjob` requires branch name for -p |
|||
Issue descriptionThe older alternative, cbuildbot, allowed -p for local changes. With `cbuildbot --remote -p <project-name> lakitu-pre-cq`, it would apply my change from the locally checked branch and run a trybot. `cros tryjob --help` says the same about -p, but apparently it always requires branch name, and the format has to be `<project-name>:<branch-name>`, which is not documented. Originally reported here: https://groups.google.com/a/chromium.org/d/msg/chromium-os-dev/NlQam38ecLY/N7VgihncAgAJ
,
Sep 26 2017
Seems like using HEAD as the default branch name would probably solve this.
,
Sep 26 2017
Another thing that could be improved is the error message. Today it has this: $ cros tryjob -p chromiumos/platform/crosutils lakitu-incremental Verifying patches... 16:31:27: ERROR: cros tryjob failed before completing. 16:31:27: ERROR: need more than 1 value to unpack Which isn't very useful.
,
Sep 26 2017
,
Sep 26 2017
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/313b01911b201325271b702f5c4762b944f77dae commit 313b01911b201325271b702f5c4762b944f77dae Author: Don Garrett <dgarrett@google.com> Date: Tue Sep 26 20:36:04 2017 patch: Discover branch for local patches. This resurrects a function that was removed from cbuildbot when tryjob support was removed. It seems more appropriate to add this logic here than in cros tryjob. The function was modified in that it now accepts a manifest arguments instead of a source root from which to construct a manifest object. Additional patching examples were added to cros tryjob. BUG= chromium:768615 TEST=cros tryjob -p chromiumos/chromite daisy-compile-only-pre-cq Change-Id: Iaeacbd6e9b41896149496675bb1bae0e65fc5c87 Reviewed-on: https://chromium-review.googlesource.com/683694 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Daniel Wang <wonderfly@google.com> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/313b01911b201325271b702f5c4762b944f77dae/lib/patch.py [modify] https://crrev.com/313b01911b201325271b702f5c4762b944f77dae/cli/cros/cros_tryjob.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by wonderfly@google.com
, Sep 25 2017