New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768606 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 795937



Sign in to add a comment

Add support for IPP over USB

Project Member Reported by weifangsun@chromium.org, Sep 25 2017

Issue description

Add support for IPP over USB to enable auto-configuration of printers which are connected directly via USB vs. the network.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/17a0a1b31619f9563bd0b83a5915a7957c5dbb03

commit 17a0a1b31619f9563bd0b83a5915a7957c5dbb03
Author: David Valleau <valleau@chromium.org>
Date: Thu Nov 30 02:05:01 2017

Adding ippusb group overlay

BUG= chromium:768606 
TEST=manually verify that group exists on device

Change-Id: I8ac6a4c6e616f83e822b0025615098ecb6739ae8
Reviewed-on: https://chromium-review.googlesource.com/791250
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/17a0a1b31619f9563bd0b83a5915a7957c5dbb03/profiles/base/accounts/group/ippusb

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/78e829a75ca10d1fbcbeca836e7cf6bbc047960d

commit 78e829a75ca10d1fbcbeca836e7cf6bbc047960d
Author: David Valleau <valleau@chromium.org>
Date: Sat Dec 02 04:32:36 2017

Adding the ippusb group

BUG= chromium:768606 
TEST=manually verify that group exists on device

Change-Id: I3e1c676b67bb4ab76ac8d30d623800a74db9ecb1
Reviewed-on: https://chromium-review.googlesource.com/791310
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Sean Kau <skau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/78e829a75ca10d1fbcbeca836e7cf6bbc047960d/client/site_tests/security_AccountsBaseline/baseline.group
[modify] https://crrev.com/78e829a75ca10d1fbcbeca836e7cf6bbc047960d/client/site_tests/security_AccountsBaseline/baseline.passwd

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7f132284953ca483045fce70e03bbbf6a6b886ad

commit 7f132284953ca483045fce70e03bbbf6a6b886ad
Author: David Valleau <valleau@chromium.org>
Date: Wed Dec 06 22:28:57 2017

net-print/ippusbxd: Adding ebuild for ippusbxd

BUG= chromium:768606 
TEST=works successfully with emerge

Change-Id: Ie25b9a05074902fa40995a0e3e9a65b6b1d6e594
Reviewed-on: https://chromium-review.googlesource.com/770512
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[add] https://crrev.com/7f132284953ca483045fce70e03bbbf6a6b886ad/net-print/ippusbxd/ippusbxd-1.30.ebuild
[add] https://crrev.com/7f132284953ca483045fce70e03bbbf6a6b886ad/net-print/ippusbxd/Manifest

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/9c665e14d50728448b9e6d9e048291932b6af19b

commit 9c665e14d50728448b9e6d9e048291932b6af19b
Author: David Valleau <valleau@chromium.org>
Date: Fri Dec 08 11:59:18 2017

Adding ippusb user

BUG= chromium:768606 
TEST=Manually tested creation of user using emerge

Change-Id: I93e45122ad241e61b52fe648aa5c772da1a4550c
Reviewed-on: https://chromium-review.googlesource.com/816359
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/9c665e14d50728448b9e6d9e048291932b6af19b/profiles/base/accounts/group/ippusb
[add] https://crrev.com/9c665e14d50728448b9e6d9e048291932b6af19b/profiles/base/accounts/user/ippusb

Blockedon: 795937
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/aad734b2b8e47248cc85fd0c477785c25605c3dd

commit aad734b2b8e47248cc85fd0c477785c25605c3dd
Author: David Valleau <valleau@chromium.org>
Date: Tue Jan 09 03:56:47 2018

debugd: Adding the "ippusb" scheme as one that supports ipp everywhere

BUG= chromium:768606 
TEST=tested manually on chromebook

Change-Id: Idb0d1aeb0015b10dc85cd0280f6eed4ad36685f6
Reviewed-on: https://chromium-review.googlesource.com/843595
Commit-Ready: Sean Kau <skau@chromium.org>
Tested-by: Sean Kau <skau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/aad734b2b8e47248cc85fd0c477785c25605c3dd/debugd/src/cups_tool.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b4256bfd16e87c452fca6c925e25954a287073fa

commit b4256bfd16e87c452fca6c925e25954a287073fa
Author: David Valleau <valleau@chromium.org>
Date: Fri Jan 19 01:40:26 2018

group_baseline: Adding group ippusb

BUG= chromium:768606 
TEST=Ran ImageTest locally on machine

Change-Id: Ib83ca77249aed822935cd9bc73d3124f1e4f6525
Reviewed-on: https://chromium-review.googlesource.com/860982
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b4256bfd16e87c452fca6c925e25954a287073fa/cros/test/usergroup_baseline.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/042accef4c55ea96d2b8268005768c3bec51bc30

commit 042accef4c55ea96d2b8268005768c3bec51bc30
Author: David Valleau <valleau@chromium.org>
Date: Sat Jan 20 01:18:09 2018

net-print/cups: Adding a patch to cups to support ippusb

BUG= chromium:768606 
TEST=Able to succesfully apply patch using emerge

Change-Id: I7e40312c4929f9d4ecbb3d1c37fd56aac7e145c4
Reviewed-on: https://chromium-review.googlesource.com/817524
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[add] https://crrev.com/042accef4c55ea96d2b8268005768c3bec51bc30/net-print/cups/files/cups-2.1.4-ippusb-query.patch
[rename] https://crrev.com/042accef4c55ea96d2b8268005768c3bec51bc30/net-print/cups/cups-2.1.4-r33.ebuild
[modify] https://crrev.com/042accef4c55ea96d2b8268005768c3bec51bc30/net-print/cups/cups-2.1.4.ebuild

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/09f466434cdc8f4182df9405612b2e211393cabe

commit 09f466434cdc8f4182df9405612b2e211393cabe
Author: David Valleau <valleau@chromium.org>
Date: Sat Jan 20 01:18:06 2018

debugd: Adding ability to inherit usergroups to SandboxedProcess

BUG= chromium:768606 
TEST=tested manually on chromebook
CQ-DEPEND=CL:843595

Change-Id: I355105b612b7bed4da659d050d225f76dd23b699
Reviewed-on: https://chromium-review.googlesource.com/849612
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/09f466434cdc8f4182df9405612b2e211393cabe/debugd/src/cups_tool.cc
[modify] https://crrev.com/09f466434cdc8f4182df9405612b2e211393cabe/debugd/src/sandboxed_process.cc
[modify] https://crrev.com/09f466434cdc8f4182df9405612b2e211393cabe/debugd/src/sandboxed_process.h

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3cc3ad612a50a432e32dc0c043444873763c6c7b

commit 3cc3ad612a50a432e32dc0c043444873763c6c7b
Author: David Valleau <valleau@chromium.org>
Date: Thu Jan 25 10:43:21 2018

ippusb_manager: Adding ippusb_manager and corresponding upstart scripts

BUG= chromium:768606 
TEST=Tested fully on chromebook and wrote unit test
CQ-DEPEND=CL:791250,CL:791310

Change-Id: I5947d536ae1501db0e000fa87b6093c12a59e7ee
Reviewed-on: https://chromium-review.googlesource.com/798790
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/socket_connection.cc
[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/ippusb_manager.gyp
[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/socket_connection.h
[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/etc/init/ippusb.conf
[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/usb.h
[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/OWNERS
[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/etc/init/ippusb-post-upstart-socket-bridge.conf
[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/usb.cc
[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/README.md
[modify] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/README.md
[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/usb_unittest.cc
[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/ippusb_manager.cc
[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/udev/99-ippusb.rules
[add] https://crrev.com/3cc3ad612a50a432e32dc0c043444873763c6c7b/ippusb_manager/etc/init/ippusb-pre-upstart-socket-bridge.conf

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/619d14b6ffd38759e6098345c476cb0342a34815

commit 619d14b6ffd38759e6098345c476cb0342a34815
Author: David Valleau <valleau@chromium.org>
Date: Mon Jan 29 21:54:20 2018

net-print/ippusbxd: Adding support for unix sockets to ippusbxd

BUG= chromium:768606 
TEST=Tested manually on chromebook
CQ-DEPEND=CL:770512

Change-Id: I59d8452c4b54c82d16c5894f38402c56e4ea39bc
Reviewed-on: https://chromium-review.googlesource.com/770514
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/619d14b6ffd38759e6098345c476cb0342a34815/net-print/ippusbxd/files/unix-socket.patch
[modify] https://crrev.com/619d14b6ffd38759e6098345c476cb0342a34815/net-print/ippusbxd/ippusbxd-1.30.ebuild
[add] https://crrev.com/619d14b6ffd38759e6098345c476cb0342a34815/net-print/ippusbxd/ippusbxd-1.30-r1.ebuild

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0dd6c4dc8034bf8cde19e779e88f6a49ddb63a62

commit 0dd6c4dc8034bf8cde19e779e88f6a49ddb63a62
Author: David Valleau <valleau@chromium.org>
Date: Mon Jan 29 21:54:19 2018

platform2/ippusb_manager: Adding ebuild for ippusb_manager

BUG= chromium:768606 
TEST=successfully builds using emerge
CQ-DEPEND=CL:798790

Change-Id: If5cab75f4e2036970d922c93a62ab6a5070c9e4f
Reviewed-on: https://chromium-review.googlesource.com/798830
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/0dd6c4dc8034bf8cde19e779e88f6a49ddb63a62/chromeos-base/ippusb_manager/ippusb_manager-9999.ebuild

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6d8931e7619e8197c5bfccf6f197e92fb52e65ff

commit 6d8931e7619e8197c5bfccf6f197e92fb52e65ff
Author: David Valleau <valleau@chromium.org>
Date: Tue Jan 30 00:38:29 2018

platform2/ippusb_manager: Adding ippusb group & user to manager ebuild

BUG= chromium:768606 
TEST=Verified that groups are added using emerge
CQ-DEPEND=CL:798830

Change-Id: I5c63f7de6421c98ecbef5a14e0eb3e3c0bf06960
Reviewed-on: https://chromium-review.googlesource.com/812963
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6d8931e7619e8197c5bfccf6f197e92fb52e65ff/chromeos-base/ippusb_manager/ippusb_manager-9999.ebuild

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9d8c8f060cdbcf3e876ede7a9fcb73800349a761

commit 9d8c8f060cdbcf3e876ede7a9fcb73800349a761
Author: David Valleau <valleau@chromium.org>
Date: Tue Jan 30 04:39:13 2018

net-print/ippusbxd: Fixing logging code to use correct syslog function

BUG= chromium:768606 
TEST=tested manually on chromebook

Change-Id: I13ca6b0e1d1982ebac2c6d821ceb0e839ceadbff
Reviewed-on: https://chromium-review.googlesource.com/854982
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/9d8c8f060cdbcf3e876ede7a9fcb73800349a761/net-print/ippusbxd/files/ippusbxd-1.31-fix-syslog.patch
[rename] https://crrev.com/9d8c8f060cdbcf3e876ede7a9fcb73800349a761/net-print/ippusbxd/ippusbxd-1.30-r2.ebuild
[modify] https://crrev.com/9d8c8f060cdbcf3e876ede7a9fcb73800349a761/net-print/ippusbxd/ippusbxd-1.30.ebuild

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6ecc1febe1173a22e20cc3ef3b1b8b121d4ac8e1

commit 6ecc1febe1173a22e20cc3ef3b1b8b121d4ac8e1
Author: David Valleau <valleau@chromium.org>
Date: Fri Feb 02 18:17:15 2018

net-print/cups: Adding nanosleep calls to lpadmin policy files

The patch to cups to support ipp-over-usb added a call to usleep() so
the policy file must be updated.

BUG= chromium:768606 
TEST=tested manually on chromebook

Change-Id: I9aee42dcacf216bf6ff38f14714ed7d9ad28466d
Reviewed-on: https://chromium-review.googlesource.com/885086
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6ecc1febe1173a22e20cc3ef3b1b8b121d4ac8e1/net-print/cups/files/lpadmin-seccomp-amd64.policy
[modify] https://crrev.com/6ecc1febe1173a22e20cc3ef3b1b8b121d4ac8e1/net-print/cups/files/lpadmin-seccomp-x86.policy
[rename] https://crrev.com/6ecc1febe1173a22e20cc3ef3b1b8b121d4ac8e1/net-print/cups/cups-2.1.4-r35.ebuild
[modify] https://crrev.com/6ecc1febe1173a22e20cc3ef3b1b8b121d4ac8e1/net-print/cups/files/lpadmin-seccomp-arm.policy

Comment 16 by skau@chromium.org, Feb 5 2018

Labels: M-66 Pri-2 Type-Feature
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/35499124e3947516892ad4b8ce4e7b89e0df427e

commit 35499124e3947516892ad4b8ce4e7b89e0df427e
Author: David Valleau <valleau@chromium.org>
Date: Tue Feb 06 03:08:57 2018

ippusb_manager: Fixing location of ippusbxd

BUG= chromium:768606 
TEST=tested manually on chromebook

Change-Id: I3c3be5b86054938702666aa7569250796720464f
Reviewed-on: https://chromium-review.googlesource.com/902164
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/35499124e3947516892ad4b8ce4e7b89e0df427e/ippusb_manager/ippusb_manager.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d09dff52c5051449e6cb2f34f188f5cb7dc384a

commit 1d09dff52c5051449e6cb2f34f188f5cb7dc384a
Author: David Valleau <valleau@chromium.org>
Date: Tue Feb 06 20:15:21 2018

Updating PrinterProtocol UMA enum to include ippusb

This update to the enum refers to this change (https://chromium-review.googlesource.com/c/chromium/src/+/842691)

R=skau@chromium.org

Bug:  768606 
Change-Id: I377ffce7ba22bc47c692c6b4885d43a9dcb86674
Reviewed-on: https://chromium-review.googlesource.com/857886
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: David Valleau <valleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534769}
[modify] https://crrev.com/1d09dff52c5051449e6cb2f34f188f5cb7dc384a/tools/metrics/histograms/enums.xml

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ae35e4759ee37cb726f5e33064654eb3326930b2

commit ae35e4759ee37cb726f5e33064654eb3326930b2
Author: David Valleau <valleau@chromium.org>
Date: Wed Feb 07 02:18:47 2018

net-print/ippusbxd: Removing use flags for hard dependencies

BUG= chromium:768606 
TEST=tested using emerge

Change-Id: I8debec6a90e1c6ed11dee8264298e484ece19eb4
Reviewed-on: https://chromium-review.googlesource.com/904963
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/ae35e4759ee37cb726f5e33064654eb3326930b2/net-print/ippusbxd/ippusbxd-1.30.ebuild
[rename] https://crrev.com/ae35e4759ee37cb726f5e33064654eb3326930b2/net-print/ippusbxd/ippusbxd-1.30-r3.ebuild

Labels: -M-66 M-67
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2e32377961724ede6cd683fbf5378e1f3b34b9d3

commit 2e32377961724ede6cd683fbf5378e1f3b34b9d3
Author: David Valleau <valleau@chromium.org>
Date: Fri Mar 16 04:23:33 2018

Updating the ippusbxd package to the latest tagged release

Also removing the "syslog" patch as it is no longer needed in the latest
version.

BUG= chromium:768606 
TEST=Able to successfully emerge and deploy package to device

Change-Id: I0dc672c90dea34444321d1f12c7398a984f47884
Reviewed-on: https://chromium-review.googlesource.com/961814
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[delete] https://crrev.com/bdfbbc6ad2629c3a6eb8301e10407bbf5a628d7f/net-print/ippusbxd/files/ippusbxd-1.31-fix-syslog.patch
[delete] https://crrev.com/bdfbbc6ad2629c3a6eb8301e10407bbf5a628d7f/net-print/ippusbxd/ippusbxd-1.30-r3.ebuild
[rename] https://crrev.com/2e32377961724ede6cd683fbf5378e1f3b34b9d3/net-print/ippusbxd/ippusbxd-1.32.ebuild
[modify] https://crrev.com/2e32377961724ede6cd683fbf5378e1f3b34b9d3/net-print/ippusbxd/Manifest

Project Member

Comment 22 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e3f1c5d66b45b467833a60e837f200c173acbfd0

commit e3f1c5d66b45b467833a60e837f200c173acbfd0
Author: David Valleau <valleau@chromium.org>
Date: Wed Mar 21 02:30:09 2018

Rebasing the unix socket patch for the newest release of ippusbxd

BUG= chromium:768606 
TEST=Able to successfully emerge and deploy to device
CQ-DEPEND=CL:961814

Change-Id: I54334edfe344d7f8ca18fd1eeb2b02a7b9c59459
Reviewed-on: https://chromium-review.googlesource.com/964945
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/e3f1c5d66b45b467833a60e837f200c173acbfd0/net-print/ippusbxd/files/unix-socket.patch
[add] https://crrev.com/e3f1c5d66b45b467833a60e837f200c173acbfd0/net-print/ippusbxd/ippusbxd-1.32-r1.ebuild

Project Member

Comment 23 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dd14a7edcc41dc7bd0431c881b1b3bbb4c992e83

commit dd14a7edcc41dc7bd0431c881b1b3bbb4c992e83
Author: David Valleau <valleau@chromium.org>
Date: Fri Mar 23 21:50:58 2018

net-print/ippusbxd: Patching ippusbxd to hold usb interfaces

BUG= chromium:768606 
TEST=Manually tested on chromebook

The current version of ippusbxd claims a USB interface and subsequently
releases it for each connection that CUPS makes to the printer.
Unfortunately, some printers misbehave when one interface is released
while a different interface is in the middle of transferring data.

This change will have ippusbxd claim all of the needed USB interfaces at
the time of startup, and only release them once the program has
completed.

Change-Id: Iae44d3a8ff5112656578ce99c75f467c69624945
Reviewed-on: https://chromium-review.googlesource.com/965242
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/dd14a7edcc41dc7bd0431c881b1b3bbb4c992e83/net-print/ippusbxd/ippusbxd-1.32.ebuild
[rename] https://crrev.com/dd14a7edcc41dc7bd0431c881b1b3bbb4c992e83/net-print/ippusbxd/ippusbxd-1.32-r2.ebuild
[add] https://crrev.com/dd14a7edcc41dc7bd0431c881b1b3bbb4c992e83/net-print/ippusbxd/files/hold-usb-interfaces.patch

Project Member

Comment 25 by bugdroid1@chromium.org, Mar 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8b961c1634c67166bfa01017616dc27a888da2a4

commit 8b961c1634c67166bfa01017616dc27a888da2a4
Author: David Valleau <valleau@chromium.org>
Date: Sat Mar 31 04:53:36 2018

net-print/ippusbxd: Changing communication code to be bidirectional

BUG= chromium:768606 
TEST=Tested manually on device using a handful of different printers
CQ-DEPEND=CL:965242

Communication between the printer and CUPS was implemented in a way
which only read from one end at a time. This change uses two threads
which are responsible for reading from one end and sending it to the
other, which removes the need to make any assumptions about whose "turn"
it is to transfer data.

Change-Id: Ia02167d67930d276c86e828614e80bcd1c483a7f
Reviewed-on: https://chromium-review.googlesource.com/969789
Commit-Ready: Sean Kau <skau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[rename] https://crrev.com/8b961c1634c67166bfa01017616dc27a888da2a4/net-print/ippusbxd/ippusbxd-1.32-r4.ebuild
[add] https://crrev.com/8b961c1634c67166bfa01017616dc27a888da2a4/net-print/ippusbxd/files/multithreaded-communication.patch
[modify] https://crrev.com/8b961c1634c67166bfa01017616dc27a888da2a4/net-print/ippusbxd/ippusbxd-1.32.ebuild

Comment 26 by skau@chromium.org, Apr 5 2018

Labels: -M-67 M-68
Status: Started (was: Assigned)
Project Member

Comment 27 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/94d2521695b6ea9d549e7405c66462f312806106

commit 94d2521695b6ea9d549e7405c66462f312806106
Author: David Valleau <valleau@chromium.org>
Date: Fri Apr 06 05:12:40 2018

ippusb_manager: Fix unittests to use underscore as separator

The manager was updated to parse a vid and pid separated by an
underscore, updating the unit tests to reflect this change.

BUG= chromium:768606 
TEST=Tests ran and passed

Change-Id: I4f3f9bc9c6b37f3ad86b4a70302bd475c1f6c8c3
Reviewed-on: https://chromium-review.googlesource.com/997104
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Sean Kau <skau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/94d2521695b6ea9d549e7405c66462f312806106/ippusb_manager/usb_unittest.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/03d34e86e015ea8d54365e01edf47fa984129b1b

commit 03d34e86e015ea8d54365e01edf47fa984129b1b
Author: David Valleau <valleau@chromium.org>
Date: Thu Apr 12 01:08:21 2018

ippusb_manager: Adding seccomp policies to ippusb_manager

BUG= chromium:768606 
TEST=Tested manually on amd64 and arm devices

Change-Id: Ib7ddd554db020c24993c7f0fdf72bc4c1719723c
Reviewed-on: https://chromium-review.googlesource.com/964710
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/03d34e86e015ea8d54365e01edf47fa984129b1b/ippusb_manager/etc/init/ippusb.conf
[add] https://crrev.com/03d34e86e015ea8d54365e01edf47fa984129b1b/ippusb_manager/seccomp/ippusb-manager-seccomp-amd64.policy
[add] https://crrev.com/03d34e86e015ea8d54365e01edf47fa984129b1b/ippusb_manager/seccomp/ippusb-manager-seccomp-arm.policy

Project Member

Comment 29 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d7772d1d4950f9c1165b1954bd6527ad1c0fe47f

commit d7772d1d4950f9c1165b1954bd6527ad1c0fe47f
Author: David Valleau <valleau@chromium.org>
Date: Thu Apr 12 01:08:22 2018

platform2/ippusb_manager: Installing seccomp policies for ippusb_manager

BUG= chromium:768606 
TEST=Able to successfully deploy and run ippusb_manager on chromebook
CQ-DEPEND=CL:964710

Change-Id: I3c42d288e05a875eb10ffd659852e5f2c8147f23
Reviewed-on: https://chromium-review.googlesource.com/964705
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/d7772d1d4950f9c1165b1954bd6527ad1c0fe47f/chromeos-base/ippusb_manager/ippusb_manager-9999.ebuild

Project Member

Comment 30 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/85c5650da7f4942ae53e713e58eed008bf4f3ee5

commit 85c5650da7f4942ae53e713e58eed008bf4f3ee5
Author: David Valleau <valleau@chromium.org>
Date: Thu Apr 12 01:08:33 2018

virtual/chromium-os-printing: Adding ippusb_manager as a dependency

BUG= chromium:768606 
TEST=Able to successfully emerge

Change-Id: I735e2f5db1a366e3433d7a52054bed0d9cf97e63
Reviewed-on: https://chromium-review.googlesource.com/996639
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/85c5650da7f4942ae53e713e58eed008bf4f3ee5/virtual/chromium-os-printing/chromium-os-printing-1.ebuild
[rename] https://crrev.com/85c5650da7f4942ae53e713e58eed008bf4f3ee5/virtual/chromium-os-printing/chromium-os-printing-1-r2.ebuild

Project Member

Comment 31 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1c9949f4bfc69344fee124553016e98ec4a7d9ac

commit 1c9949f4bfc69344fee124553016e98ec4a7d9ac
Author: David Valleau <valleau@chromium.org>
Date: Thu Apr 12 01:09:09 2018

chromeos-base/ippusb_manager: Adding ippusbxd as a dependency

BUG= chromium:768606 
TEST=Able to successfully emerge

Change-Id: Ied4b85bd4afcabf73e46de7a785546adaa41e7f0
Reviewed-on: https://chromium-review.googlesource.com/996641
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/1c9949f4bfc69344fee124553016e98ec4a7d9ac/chromeos-base/ippusb_manager/ippusb_manager-9999.ebuild

Project Member

Comment 32 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16c5c8694ca07274904818644ca38b4278f46f35

commit 16c5c8694ca07274904818644ca38b4278f46f35
Author: David Valleau <valleau@chromium.org>
Date: Mon Apr 16 19:11:50 2018

Adding detections for ipp-over-usb printers

This change checks the interfaces on a detected USB printer to see if any of
them support ipp-over-usb. A new flag has been added to the Printer class to
indicate whether or not it does.

Once the printer has been detected, in the event that we don't have a PPD for it
and it supports ipp-over-usb then we set it up as an ipp everywhere printer.

R=justincarlson@chromium.org, skau@chromium.org

Bug:  768606 
Change-Id: I38214e0ce4f8ecee262ae94ac548cd79626f8a82
Reviewed-on: https://chromium-review.googlesource.com/842691
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551064}
[modify] https://crrev.com/16c5c8694ca07274904818644ca38b4278f46f35/chrome/browser/chromeos/printing/cups_printers_manager.cc
[modify] https://crrev.com/16c5c8694ca07274904818644ca38b4278f46f35/chrome/browser/chromeos/printing/usb_printer_util.cc
[modify] https://crrev.com/16c5c8694ca07274904818644ca38b4278f46f35/chrome/browser/chromeos/printing/usb_printer_util.h
[modify] https://crrev.com/16c5c8694ca07274904818644ca38b4278f46f35/chromeos/printing/printer_configuration.cc
[modify] https://crrev.com/16c5c8694ca07274904818644ca38b4278f46f35/chromeos/printing/printer_configuration.h

Project Member

Comment 33 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16c5c8694ca07274904818644ca38b4278f46f35

commit 16c5c8694ca07274904818644ca38b4278f46f35
Author: David Valleau <valleau@chromium.org>
Date: Mon Apr 16 19:11:50 2018

Adding detections for ipp-over-usb printers

This change checks the interfaces on a detected USB printer to see if any of
them support ipp-over-usb. A new flag has been added to the Printer class to
indicate whether or not it does.

Once the printer has been detected, in the event that we don't have a PPD for it
and it supports ipp-over-usb then we set it up as an ipp everywhere printer.

R=justincarlson@chromium.org, skau@chromium.org

Bug:  768606 
Change-Id: I38214e0ce4f8ecee262ae94ac548cd79626f8a82
Reviewed-on: https://chromium-review.googlesource.com/842691
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551064}
[modify] https://crrev.com/16c5c8694ca07274904818644ca38b4278f46f35/chrome/browser/chromeos/printing/cups_printers_manager.cc
[modify] https://crrev.com/16c5c8694ca07274904818644ca38b4278f46f35/chrome/browser/chromeos/printing/usb_printer_util.cc
[modify] https://crrev.com/16c5c8694ca07274904818644ca38b4278f46f35/chrome/browser/chromeos/printing/usb_printer_util.h
[modify] https://crrev.com/16c5c8694ca07274904818644ca38b4278f46f35/chromeos/printing/printer_configuration.cc
[modify] https://crrev.com/16c5c8694ca07274904818644ca38b4278f46f35/chromeos/printing/printer_configuration.h

Status: Fixed (was: Started)
Marking this as fixed.

In the latest version of Chrome/ChromeOS users should be able to add USB printers and if we do not have a PPD for the printer then ipp-over-usb printing will be used as a fallback method.
Project Member

Comment 35 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/02499896444f016f0dc425040b9523d179bed21f

commit 02499896444f016f0dc425040b9523d179bed21f
Author: David Valleau <valleau@chromium.org>
Date: Thu Apr 19 05:31:12 2018

net-print/ippusbxd: Changing thread cleanup handler to deallocate params

BUG= chromium:768606 
TEST=Tested manually on chromebook

Change-Id: Ib5a0d55f80629d2d8cc31d4699b9d94c92cb62f8
Reviewed-on: https://chromium-review.googlesource.com/1016125
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[add] https://crrev.com/02499896444f016f0dc425040b9523d179bed21f/net-print/ippusbxd/files/thread-cleanup.patch
[rename] https://crrev.com/02499896444f016f0dc425040b9523d179bed21f/net-print/ippusbxd/ippusbxd-1.32-r5.ebuild
[modify] https://crrev.com/02499896444f016f0dc425040b9523d179bed21f/net-print/ippusbxd/ippusbxd-1.32.ebuild

Sign in to add a comment