[Findit] Update message to sheriffs on revert's code review |
||
Issue descriptionAfter auto_commit is enabled, we would not need sheriffs to LGTM and commit reverts. So we need to update the message we included when adding reviewers. As suggested by stgao@, we can submit the revert first, and choose different reviewers and messages based on result of the commit.
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b8d5d9dc9aa1c8704021b958e5c4296ad708827a commit b8d5d9dc9aa1c8704021b958e5c4296ad708827a Author: Chan <chanli@chromium.org> Date: Wed Oct 11 17:19:09 2017 [Findit] Send different different messages when add reviewers based on revert status. 1. If Findit will only create the revert or failed to submit the revert, add sheriffs as reviewers and ask them to +1 and CQ the revert; 2. If Findit successfully submit the change, add sheriffs as reviewers and ask them to confirm the culprit is correct, or revert and submit a bug; Bug: 768602 Change-Id: Ie70e03259a578bc8d490eb63f7be775381f2f08b Reviewed-on: https://chromium-review.googlesource.com/688854 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/b8d5d9dc9aa1c8704021b958e5c4296ad708827a/appengine/findit/services/revert.py [modify] https://crrev.com/b8d5d9dc9aa1c8704021b958e5c4296ad708827a/appengine/findit/common/constants.py [modify] https://crrev.com/b8d5d9dc9aa1c8704021b958e5c4296ad708827a/appengine/findit/services/test/revert_test.py [modify] https://crrev.com/b8d5d9dc9aa1c8704021b958e5c4296ad708827a/appengine/findit/waterfall/test/submit_revert_cl_pipeline_test.py
,
Oct 12 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by chanli@chromium.org
, Oct 10 2017