New issue
Advanced search Search tips

Issue 768599 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Remove paper-toolbar from third_party/polymer

Project Member Reported by dpa...@chromium.org, Sep 25 2017

Issue description

paper-toolbar is deprecated (see [1]), but also can be easily replaced with a simple styled div. See previous CL that did this for the PDF viewer at [2].

The only remaining usage of paper-toolbar (I think) is in CrOS is within files-quick-view, see [3].

[1] https://www.webcomponents.org/element/PolymerElements/paper-toolbar
[2] https://chromium-review.googlesource.com/c/chromium/src/+/679856
[3] https://cs.chromium.org/search/?q=paper-toolbar+file:%5Esrc/ui/file_manager/+package:%5Echromium$&type=cs
 
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/deedd4312d05f1e027995d58aea3f88841179855

commit deedd4312d05f1e027995d58aea3f88841179855
Author: dpapad <dpapad@chromium.org>
Date: Fri Sep 29 02:52:38 2017

WebUI cleanup: Remove unused paper-toolbar Polymer element.

Bug:  768599 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8104ae1a081564d66425cd0f6bdec9229f4f6c26
Reviewed-on: https://chromium-review.googlesource.com/682455
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505267}
[modify] https://crrev.com/deedd4312d05f1e027995d58aea3f88841179855/chrome/browser/resources/chromeos/emulator/device_emulator_pages.html
[modify] https://crrev.com/deedd4312d05f1e027995d58aea3f88841179855/third_party/polymer/v1_0/bower.json
[delete] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/third_party/polymer/v1_0/components-chromium/paper-toolbar/bower.json
[delete] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/third_party/polymer/v1_0/components-chromium/paper-toolbar/compiled_resources2.gyp
[delete] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/third_party/polymer/v1_0/components-chromium/paper-toolbar/paper-toolbar-extracted.js
[delete] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/third_party/polymer/v1_0/components-chromium/paper-toolbar/paper-toolbar.html
[modify] https://crrev.com/deedd4312d05f1e027995d58aea3f88841179855/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/deedd4312d05f1e027995d58aea3f88841179855/ui/webui/resources/polymer_resources.grdp

Status: Fixed (was: Started)

Sign in to add a comment