New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 768587 link

Starred by 1 user
Status: Fixed
Owner:
xidac...@chromium.org
Closed: Sep 2017
Cc:
█ junov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

draw-video-to-hw-accelerated-canvas-2d benchmark behaves poorly because of video looping

Project Member Reported by piman@chromium.org, Sep 25 2017 
Forked from  crbug.com/766556 . In a nutshell, regressions look like progressions and vice versa, because slower runs mean that the video (2.7s long) will loop before the end of the test, and while it's restarting it generates 1000x faster numbers than the common case, causing a heavy skew.

Slowing down the video 10x largely alleviates the problem (the test "should" run within 20s by construction), but possibly better would be to find a longer video asset.

Comment 1 by junov@chromium.org, Sep 26 2017

Cc: junov@chromium.org
Owner: xidac...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0a9caa5d5c6c6cb660b190c842dc0c920a91f84

commit c0a9caa5d5c6c6cb660b190c842dc0c920a91f84
Author: Xida Chen <xidachen@chromium.org>
Date: Fri Sep 29 19:25:56 2017

Fix a canvas perf test

It was found that draw-video-to-hw-accelerated-canvas-2d doesn't behave
well because the video (2.7s) will loop before the end of the test, and
that causes slower runs.

This CL added a video that is basically make the existing video 10x long.
The bots does show that this CL makes the test more stable. More specifically,
the std for number of runs per second drops from ~900 to ~100 from this:
https://00e9e64bac2c0afae7fb27bf02252c6c092b05ab07a2cd942a-apidata.googleusercontent.com/download/storage/v1/b/chromium-telemetry/o/html-results%2Fresults-2017-09-29_09-42-34?qk=AD5uMEuJ87mJb-OzfCtox1McLIVr2ep45qbDcQ8lwrQAQytJY60BiwbqbQ5cFSVp6QyAU4luW87WLT-rB7Q4ZEMs38XvabrqHAoDyXxpHT7gOb8snXCTtUq8GvesUWwrGjXv1aR24fhTcyCgCWP9pxT15ypdXcOyfQUuh2VVmJ-IhB3PoxZ2JE3t6E5iw1rqCA3pxnG9IQ_H7B2FVK3x6Y_w3LUgzjPRrmNIvHM1-clnW35L8X5AxurWZXiUAC9kOyMRFs39i6auEuXVOYImldAz4j33mMOHZSK8KKKmj80vL9I-Ejjp5FxCtRr2gqVcNPf91FLiXRTyHXACu4pO77uFCyoydzM-pWkm-ILeoKAy-t3c0Xt_cwgOeFdgENekilHGVcsVnJ47BCnw71xwcqpkHdjr406v1Mkv7hnd57IEck2HHpYE-ZfdjfFO3BUMryU7Twiwt5VVC4KHNYBLEUheuGBXnMMw11sy0yuiBmesV95cji-c9iyaHqcxYLQ0OqjPToEsGDxEvr-GLLoJU6VWRxr0l7BI1G6nbIpnNufZkP0SwGMWWHlmoSAfNdokgTUqyQTncmNln4BXXmDI011iX6xDk_dg9MAS28RCfhrzFMNB95uakTgR-l_kfwY-ODf8HeGP4T9lcQa_LOHN_jh7q93BSw5Uie7tmUa6UcxBdD6MWKvHI45aS-B-u9QKA1vClGHW5DrBQU9cMBbNDbC3WOZ0NTGN1j6FYYTgVR4ZOjPrB1qvZaWrUGCJRNMqJKY4Fa8Z69aWr_-BXoWnjC7WcnWKI8QadA

Bug:  768587 
Change-Id: I919296586a31c406e80c46648e475da79bdc5e7e
Reviewed-on: https://chromium-review.googlesource.com/692417
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505438}
[modify] https://crrev.com/c0a9caa5d5c6c6cb660b190c842dc0c920a91f84/third_party/WebKit/PerformanceTests/Canvas/draw-video-to-hw-accelerated-canvas-2d.html
[add] https://crrev.com/c0a9caa5d5c6c6cb660b190c842dc0c920a91f84/third_party/WebKit/PerformanceTests/Canvas/resources/bear-1280x720-long.mp4
[delete] https://crrev.com/357bdbf7f33061d9ecf3052813cced0e9da45498/third_party/WebKit/PerformanceTests/Canvas/resources/bear-1280x720.mp4
[modify] https://crrev.com/c0a9caa5d5c6c6cb660b190c842dc0c920a91f84/third_party/WebKit/PerformanceTests/Canvas/upload-video-to-sub-texture.html
[modify] https://crrev.com/c0a9caa5d5c6c6cb660b190c842dc0c920a91f84/third_party/WebKit/PerformanceTests/Canvas/upload-video-to-texture.html

Comment 3 by xidac...@chromium.org, Sep 29 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment