New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768586 link

Starred by 4 users

roll clang-format again

Project Member Reported by thakis@chromium.org, Sep 25 2017

Issue description

ideally, also set up some system that makes rolling clang-format much easier than having to manually build binaries on mac/linux/win.


 

Comment 1 by thakis@chromium.org, Sep 25 2017

Labels: clang-format OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Linux OS-Windows
Owner: thakis@chromium.org
Status: Untriaged (was: Unconfirmed)

Comment 2 by sczs@chromium.org, Sep 27 2017

Status: Assigned (was: Untriaged)

Comment 3 by thakis@chromium.org, Sep 27 2017

Blocking: 740162
Components: Build

Comment 5 by thakis@chromium.org, Jan 22 2018

 Issue 790047  has been merged into this issue.

Comment 6 by thakis@chromium.org, Jan 22 2018

The automated path should work similar to the upload_clang bots:..

0. (optional) Have a script to kick off builds on some bots (https://cs.chromium.org/chromium/src/tools/clang/scripts/upload_revision.py?type=cs&q=win_upload_clang&sq=package:chromium&l=78)
1. Have bots that can build clang-format (clang update bot setup is https://cs.chromium.org/chromium/build/scripts/slave/recipes/chromium_upload_clang.py?q=chromium_upload_clang&sq=package:chromium&dr mostly, see revision history to see other files that need touching for bot setup)

There's no step 2.


Optionally, we could use something like https://cs.chromium.org/chromium/build/scripts/slave/recipes/chromium_upload_clang.py?q=chromium_upload_clang&sq=package:chromium&dr to build clang-format for mac/win/linux on a mac box, then we'd only need one instead of 3 bots. (But couldn't run tests as easily, and since we need a mac, not a linux box, it's not all that useful anyhow.)

Comment 7 by thakis@chromium.org, Jan 23 2018

Blocking: 781015

Comment 8 by thakis@chromium.org, Jan 23 2018

Blocking: 793316
Cc: thakis@chromium.org nick@chromium.org
 Issue 877502  has been merged into this issue.
Blocking: 875245
This is blocking using Chromium's infra for Dawn since we are checking the formatting with a PRESUBMIT and use clang-format 6 or 7 options.
Feel free to steal! I won't get to this soon.
Blocking: 884367
Blocking: 768983
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/buildtools/+/24ebce4578745db15274e180da1938ebc1358243

commit 24ebce4578745db15274e180da1938ebc1358243
Author: Sam Maier <smaier@chromium.org>
Date: Fri Nov 16 15:36:49 2018

Update clang-format binaries and scripts for all platforms.

I followed these instructions:
https://chromium.googlesource.com/chromium/src/+/master/docs/updating_clang_format_binaries.md

The binaries were built at clang revision 346566 on November 15, 2018.

Rolling because 344070 introduces Java import reordering in
clang-format, and 346566 fixes a critical bug with Objective C.

OLD: https://chromium-review.googlesource.com/c/chromium/src/+/1296816
NEW: https://chromium-review.googlesource.com/c/chromium/src/+/1331609

ls -l output
-rwxr-xr-x 1 smaier primarygroup 1967524 Nov 15 16:47 buildtools/mac/clang-format
-rwxr-xr-x 1 smaier primarygroup 1862936 Nov 15 14:06 buildtools/linux64/clang-format
-rw-r--r-- 1 smaier primarygroup 2637824 Nov 15 14:04 buildtools/win/clang-format.exe


Bug:  768586 , 768983 
Change-Id: I2761fc91201d2ffa0d999e637f8f8ba53bcccb5e

[modify] https://crrev.com/24ebce4578745db15274e180da1938ebc1358243/linux64/clang-format.sha1
[modify] https://crrev.com/24ebce4578745db15274e180da1938ebc1358243/deps_revisions.gni
[modify] https://crrev.com/24ebce4578745db15274e180da1938ebc1358243/win/clang-format.exe.sha1
[modify] https://crrev.com/24ebce4578745db15274e180da1938ebc1358243/clang_format/README.chromium
[modify] https://crrev.com/24ebce4578745db15274e180da1938ebc1358243/DEPS
[modify] https://crrev.com/24ebce4578745db15274e180da1938ebc1358243/mac/clang-format.sha1

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf89178f52ee6fe536140f83338af3494e8355cc

commit bf89178f52ee6fe536140f83338af3494e8355cc
Author: Nico Weber <thakis@chromium.org>
Date: Wed Nov 21 02:07:20 2018

Roll src/buildtools/ 13a00f110..da9b2941c (3 commits)

https://chromium.googlesource.com/chromium/buildtools.git/+log/13a00f110ef9..da9b2941cbf6

$ git log 13a00f110..da9b2941c --date=short --no-merges --format='%ad %ae %s'
2018-11-20 thakis Revert "Roll libcxx{abi}
2018-11-16 smaier Update clang-format binaries and scripts for all platforms.
2018-10-29 thomasanderson Roll libcxx{abi}

Created with:
  roll-dep src/buildtools

Bug:  768586 , 768983 
Change-Id: Ib72e2e4f38b9ed662652a440925ff9260f97abcc
Reviewed-on: https://chromium-review.googlesource.com/c/1344293
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609898}
[modify] https://crrev.com/bf89178f52ee6fe536140f83338af3494e8355cc/DEPS

Blocking: 710441
Owner: smaier@chromium.org
Status: Started (was: Assigned)
Let's keep this open for a bit to see if issues crop up. I'll send a short announcement to chromium-dev.
Blocking: 863549
Status: Fixed (was: Started)
No reports about brokenness yet. Knock on wood :-)
Blocking: 866014
Blocking: 369454
Blocking: 451529
Blocking: 451533
Blocking: 451821
Blocking: 370608
Blocking: 370615
Blocking: 370618
Blocking: 385905
Blocking: 399463
Blocking: 421361
Blocking: -385905
Blocking: 423596
Blocking: 451363
Blocking: 451369
Blocking: 451371
Blocking: 454958
Blocking: 546175
Blocking: 585788
Blocking: -585788
Blocking: 752788
Blocking: -752788
Blocking: 752788
Blocking: 506102
Blocking: 650688
Blocking: 721911
Blocking: 762355
Blocking: 782790
Blocking: 816707
Blocking: 821377
Blocking: 870175
Blocking: -866014

Sign in to add a comment