roll clang-format again |
|||||||||||||||||||||||||||||||||||||||||||||
Issue descriptionideally, also set up some system that makes rolling clang-format much easier than having to manually build binaries on mac/linux/win.
,
Sep 27 2017
,
Sep 27 2017
,
Sep 29 2017
,
Jan 22 2018
Issue 790047 has been merged into this issue.
,
Jan 22 2018
The automated path should work similar to the upload_clang bots:.. 0. (optional) Have a script to kick off builds on some bots (https://cs.chromium.org/chromium/src/tools/clang/scripts/upload_revision.py?type=cs&q=win_upload_clang&sq=package:chromium&l=78) 1. Have bots that can build clang-format (clang update bot setup is https://cs.chromium.org/chromium/build/scripts/slave/recipes/chromium_upload_clang.py?q=chromium_upload_clang&sq=package:chromium&dr mostly, see revision history to see other files that need touching for bot setup) There's no step 2. Optionally, we could use something like https://cs.chromium.org/chromium/build/scripts/slave/recipes/chromium_upload_clang.py?q=chromium_upload_clang&sq=package:chromium&dr to build clang-format for mac/win/linux on a mac box, then we'd only need one instead of 3 bots. (But couldn't run tests as easily, and since we need a mac, not a linux box, it's not all that useful anyhow.)
,
Jan 23 2018
,
Jan 23 2018
,
Aug 25
,
Aug 29
This is blocking using Chromium's infra for Dawn since we are checking the formatting with a PRESUBMIT and use clang-format 6 or 7 options.
,
Aug 29
Feel free to steal! I won't get to this soon.
,
Oct 5
,
Oct 10
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/buildtools/+/24ebce4578745db15274e180da1938ebc1358243 commit 24ebce4578745db15274e180da1938ebc1358243 Author: Sam Maier <smaier@chromium.org> Date: Fri Nov 16 15:36:49 2018 Update clang-format binaries and scripts for all platforms. I followed these instructions: https://chromium.googlesource.com/chromium/src/+/master/docs/updating_clang_format_binaries.md The binaries were built at clang revision 346566 on November 15, 2018. Rolling because 344070 introduces Java import reordering in clang-format, and 346566 fixes a critical bug with Objective C. OLD: https://chromium-review.googlesource.com/c/chromium/src/+/1296816 NEW: https://chromium-review.googlesource.com/c/chromium/src/+/1331609 ls -l output -rwxr-xr-x 1 smaier primarygroup 1967524 Nov 15 16:47 buildtools/mac/clang-format -rwxr-xr-x 1 smaier primarygroup 1862936 Nov 15 14:06 buildtools/linux64/clang-format -rw-r--r-- 1 smaier primarygroup 2637824 Nov 15 14:04 buildtools/win/clang-format.exe Bug: 768586 , 768983 Change-Id: I2761fc91201d2ffa0d999e637f8f8ba53bcccb5e [modify] https://crrev.com/24ebce4578745db15274e180da1938ebc1358243/linux64/clang-format.sha1 [modify] https://crrev.com/24ebce4578745db15274e180da1938ebc1358243/deps_revisions.gni [modify] https://crrev.com/24ebce4578745db15274e180da1938ebc1358243/win/clang-format.exe.sha1 [modify] https://crrev.com/24ebce4578745db15274e180da1938ebc1358243/clang_format/README.chromium [modify] https://crrev.com/24ebce4578745db15274e180da1938ebc1358243/DEPS [modify] https://crrev.com/24ebce4578745db15274e180da1938ebc1358243/mac/clang-format.sha1
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf89178f52ee6fe536140f83338af3494e8355cc commit bf89178f52ee6fe536140f83338af3494e8355cc Author: Nico Weber <thakis@chromium.org> Date: Wed Nov 21 02:07:20 2018 Roll src/buildtools/ 13a00f110..da9b2941c (3 commits) https://chromium.googlesource.com/chromium/buildtools.git/+log/13a00f110ef9..da9b2941cbf6 $ git log 13a00f110..da9b2941c --date=short --no-merges --format='%ad %ae %s' 2018-11-20 thakis Revert "Roll libcxx{abi} 2018-11-16 smaier Update clang-format binaries and scripts for all platforms. 2018-10-29 thomasanderson Roll libcxx{abi} Created with: roll-dep src/buildtools Bug: 768586 , 768983 Change-Id: Ib72e2e4f38b9ed662652a440925ff9260f97abcc Reviewed-on: https://chromium-review.googlesource.com/c/1344293 Reviewed-by: Sam Maier <smaier@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#609898} [modify] https://crrev.com/bf89178f52ee6fe536140f83338af3494e8355cc/DEPS
,
Nov 21
,
Nov 21
Let's keep this open for a bit to see if issues crop up. I'll send a short announcement to chromium-dev.
,
Nov 21
,
Nov 26
No reports about brokenness yet. Knock on wood :-)
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 26
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
|
|||||||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||||||||||||
Comment 1 by thakis@chromium.org
, Sep 25 2017Owner: thakis@chromium.org
Status: Untriaged (was: Unconfirmed)