New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768580 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 769402



Sign in to add a comment

MD Extensions: error console looks different from spec

Project Member Reported by scottchen@chromium.org, Sep 25 2017

Issue description

layout issues, errors shown formatted differently, color is different.
 
Status: Started (was: Available)
Blocking: 769402
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/727be0521f94b591893ab5a1f1214369926afb58

commit 727be0521f94b591893ab5a1f1214369926afb58
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Sep 29 02:22:10 2017

MD Extensions: fix error-console sub-page looking broken.

This CL is the first pass for error-console such that it no longer looks
completely broken, as well as fixing keyboard navigation. There will be 
follow-up CLs to bring it closer to the design spec as well as adding the
missing dev-tool buttons.

Bug:  768580 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I15d85e0ebe946b11a9a7aaf9f471ba22fe705a97
Reviewed-on: https://chromium-review.googlesource.com/685988
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505257}
[modify] https://crrev.com/727be0521f94b591893ab5a1f1214369926afb58/chrome/browser/resources/md_extensions/code_section.html
[modify] https://crrev.com/727be0521f94b591893ab5a1f1214369926afb58/chrome/browser/resources/md_extensions/error_page.html
[modify] https://crrev.com/727be0521f94b591893ab5a1f1214369926afb58/chrome/browser/resources/md_extensions/error_page.js

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8a1199de9e968c0cb85165bd2c94e791c7a2aa2

commit e8a1199de9e968c0cb85165bd2c94e791c7a2aa2
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Oct 06 22:27:29 2017

MD Extensions: improvements on error-console UI

Bug:  768580 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iac15630fb34b3432b05dee306f70161d4e1d7ea4
Reviewed-on: https://chromium-review.googlesource.com/701361
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507198}
[modify] https://crrev.com/e8a1199de9e968c0cb85165bd2c94e791c7a2aa2/chrome/browser/resources/md_extensions/code_section.html
[modify] https://crrev.com/e8a1199de9e968c0cb85165bd2c94e791c7a2aa2/chrome/browser/resources/md_extensions/code_section.js
[modify] https://crrev.com/e8a1199de9e968c0cb85165bd2c94e791c7a2aa2/chrome/browser/resources/md_extensions/error_page.html
[modify] https://crrev.com/e8a1199de9e968c0cb85165bd2c94e791c7a2aa2/chrome/browser/resources/md_extensions/error_page.js
[modify] https://crrev.com/e8a1199de9e968c0cb85165bd2c94e791c7a2aa2/chrome/test/data/webui/extensions/extension_code_section_test.js
[modify] https://crrev.com/e8a1199de9e968c0cb85165bd2c94e791c7a2aa2/chrome/test/data/webui/extensions/extension_error_page_test.js
[modify] https://crrev.com/e8a1199de9e968c0cb85165bd2c94e791c7a2aa2/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
[modify] https://crrev.com/e8a1199de9e968c0cb85165bd2c94e791c7a2aa2/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.js

Status: Fixed (was: Started)

Sign in to add a comment