Clean up storage of overflow data in AudioInputSyncWriter |
||
Issue descriptionWhen the renderer cannot receive data in time, AudioInputSyncWriter stores them so the renderer can receive them later. It has two members for this, std::vector<std::unique_ptr<media::AudioBus>> overflow_buses_ for the audio data, and base::circular_deque<OverflowParams> overflow_params_ for some metadata, see https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/audio_input_sync_writer.h?l=167. It doesn't really make sense to have two members for this, especially not using different container types :). There's also a bunch of DCHECKs to make sure they don't go out of sync. I'd prefer if there was a struct holding both an AudioBus and the associated metadata, and have a single container holding those. This may be a good starter bug (of the "set up Goma and figure out Gerrit" size, not the "starter project" size).
,
Oct 6 2017
submitted patch for this issue https://chromium-review.googlesource.com/c/chromium/src/+/704495 PTAL
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46a011e1dade438944de918f63b26df678416a42 commit 46a011e1dade438944de918f63b26df678416a42 Author: k2.nagaraju <k2.nagaraju@samsung.com> Date: Tue Oct 10 09:46:55 2017 Clean up storage of overflow data in AudioInputSyncWriter Bug: 768562 Change-Id: Ied472734f32e09ff0aa15d54dcde3f74eb6b2b80 Reviewed-on: https://chromium-review.googlesource.com/704495 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#507625} [modify] https://crrev.com/46a011e1dade438944de918f63b26df678416a42/content/browser/renderer_host/media/audio_input_sync_writer.cc [modify] https://crrev.com/46a011e1dade438944de918f63b26df678416a42/content/browser/renderer_host/media/audio_input_sync_writer.h [modify] https://crrev.com/46a011e1dade438944de918f63b26df678416a42/content/browser/renderer_host/media/audio_input_sync_writer_unittest.cc
,
Oct 12 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by maxmorin@chromium.org
, Sep 25 2017