New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768562 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Clean up storage of overflow data in AudioInputSyncWriter

Project Member Reported by maxmorin@chromium.org, Sep 25 2017

Issue description

When the renderer cannot receive data in time, AudioInputSyncWriter stores them so the renderer can receive them later. It has two members for this, std::vector<std::unique_ptr<media::AudioBus>> overflow_buses_ for the audio data, and base::circular_deque<OverflowParams> overflow_params_ for some metadata, see
https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/audio_input_sync_writer.h?l=167. It doesn't really make sense to have two members for this, especially not using different container types :). There's also a bunch of DCHECKs to make sure they don't go out of sync. I'd prefer if there was a struct holding both an AudioBus and the associated metadata, and have a single container holding those.

This may be a good starter bug (of the "set up Goma and figure out Gerrit" size, not the "starter project" size).
 
Summary: Clean up storage of overflow data in AudioInputSyncWriter (was: Clean up ugly storage of overflow data in AudioInputSyncWriter)
submitted patch for this issue
https://chromium-review.googlesource.com/c/chromium/src/+/704495

PTAL
Status: Fixed (was: Available)

Sign in to add a comment