Issue metadata
Sign in to add a comment
|
17% regression in blink_perf.canvas at 503782:503871 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 27 2017
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14fde9d4780000
,
Sep 28 2017
๐ Pinpoint job completed. https://pinpoint-dot-chromeperf.appspot.com/job/14fde9d4780000 Found significant differences after 1 commit: avoid thread-jump in multibuffer_datasource::read() By hubbe@google.com ยท Fri Sep 22 21:11:16 2017 chromium@ff3b31782d552b03104a6d831c7530605b52b13f
,
Sep 28 2017
hubbe: can you take a look? See #3
,
Sep 28 2017
assigning to hubbe for real, see #3
,
Sep 28 2017
Not sure yet, but I suspect that this is working as intended. This test makes the render thread very busy, which I think is causing the video to play slower than it's supposed to. My change essentially removes this limitation, which lets the video play correctly, but takes away some cpu and gpu time from the rendering thread where the benchmark is running.
,
Sep 28 2017
Stupid question: How do I run this test?
,
Sep 28 2017
,
Sep 28 2017
+junov: benchmark owner: do you think hubbe@'s change justify the 17% regression? hubbe@: to run the benchmark: src/tools/perf/run_benchmark blink_perf.canvas --browser<...>
,
Sep 29 2017
To really see what is going on, try changing the test to run 100 iterations.
You can turn my change off by changing media/blink/multibuffer_data_source.cc:358 from:
if(reader_) {
to:
if (0) {
With the change off, the video hangs repeatedly as the test is running. With my change on, the video keeps playing smoothly. This isn't actually affecting the speed of subtextures, but it is affecting this benchmark.
Marking as WontFix.
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 25 2017