NOTREACHED() on yahoo.com with subresource filtering force-enabled |
||
Issue descriptionChrome Version: ToT What steps will reproduce the problem? (1) Use command line flags as below: --force-fieldtrials=SF/Enabled --force-fieldtrial-params=SF.Enabled:activation_state/enabled/activation_scope/all_sites --enable-features="SubresourceFilter<SF" This equals to activate subresource filtering on all sites. (2) load yahoo.com (3) observe [FATAL:StyleAdjuster.cpp(111)] Check failed: false. base::debug::StackTrace::StackTrace() at /mnt/srcstore/src/trunk/src/out/Debug/../../base/debug/stack_trace.cc:199 logging::LogMessage::~LogMessage() at /mnt/srcstore/src/trunk/src/out/Debug/../../base/logging.cc:537 EquivalentBlockDisplay at /mnt/srcstore/src/trunk/src/out/Debug/../../third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp:91 (discriminator 5) blink::StyleAdjuster::AdjustComputedStyle(blink::ComputedStyle&, blink::ComputedStyle const&, blink::ComputedStyle const&, blink::Element*) at /mnt/srcstore/src/trunk/src/out/Debug/../../third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp:421 (discriminator 1) blink::StyleResolver::AdjustComputedStyle(blink::StyleResolverState&, blink::Element*) at /mnt/srcstore/src/trunk/src/out/Debug/../../third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp:616 (discriminator 1) blink::StyleResolver::StyleForElement(blink::Element*, blink::ComputedStyle const*, blink::ComputedStyle const*, blink::StyleSharingBehavior, blink::RuleMatchingBehavior) at /mnt/srcstore/src/trunk/src/out/Debug/../../third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp:807 ...
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc74a9f337edc46491a1ba957e38e030c7d5e384 commit bc74a9f337edc46491a1ba957e38e030c7d5e384 Author: Balazs Kelemen <b.kelemen@samsung.com> Date: Fri Sep 29 19:10:40 2017 Recheck for display:none in StyleAdjuster after calling AdjustStyleForHTMLElement AdjustStyleForHTMLElement might set display:none. This can happen for a HTMLImageElement that returns true for IsCollapsed(). Therefore the condition should be checked again. Bug: 768546 Change-Id: I77b441a19f713018b89afa4f460501f9ca96275a Reviewed-on: https://chromium-review.googlesource.com/683006 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Balazs Kelemen <b.kelemen@samsung.com> Cr-Commit-Position: refs/heads/master@{#505436} [add] https://crrev.com/bc74a9f337edc46491a1ba957e38e030c7d5e384/third_party/WebKit/LayoutTests/http/tests/subresource_filter/collapsed-image-style-crash.html [modify] https://crrev.com/bc74a9f337edc46491a1ba957e38e030c7d5e384/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
,
Oct 2 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by nparker@chromium.org
, Sep 26 2017