Issue metadata
Sign in to add a comment
|
7.1%-33.7% regression in rasterize_and_record_micro.top_25 at 503573:503658 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 25 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8967446012945963952
,
Sep 25 2017
=== Auto-CCing suspected CL author enne@chromium.org === Hi enne@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Adrienne Walker Commit : 92d549f9ab9342c069a1c4c335eeccabd5ed93d1 Date : Thu Sep 21 23:59:46 2017 Subject: cc: Decode "at raster" images at raster task start Bisect Details Configuration: mac_10_12_perf_bisect Benchmark : rasterize_and_record_micro.top_25 Metric : rasterize_time/file___static_top_25_googleplus.html Change : 33.92% | 4.78783333333 -> 6.41183333333 Revision Result N chromium@503610 4.78783 +- 0.0195661 6 good chromium@503616 4.782 +- 0.0252982 6 good chromium@503617 6.43183 +- 0.0569283 6 bad <-- chromium@503618 6.4235 +- 0.0461898 6 bad chromium@503619 6.4105 +- 0.0376763 6 bad chromium@503622 6.40983 +- 0.0208046 6 bad chromium@503634 6.441 +- 0.158707 6 bad chromium@503658 6.41183 +- 0.0856086 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=file...static.top.25.googleplus.html rasterize_and_record_micro.top_25 More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8967446012945963952 For feedback, file a bug with component Speed>Bisection
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d1be840afed203dee9425853a0a64b9d61cdd3b commit 5d1be840afed203dee9425853a0a64b9d61cdd3b Author: Khushal <khushalsagar@chromium.org> Date: Fri Sep 29 17:51:17 2017 cc: Address raster regression from PlaybackImageProvider construction. Adding additional parameters to PlaybackImageProvider ctor causes a regression in total raster time on some mac configs. In order to address this, break out these settings to a separate struct which can optionally be given to the provider. The params are modified on the Settings object post construction. R=enne@chromium.org Bug: 768538 , 768543 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0e7fc0df225826e5a26f0f9d09c106a6b2d1f640 Reviewed-on: https://chromium-review.googlesource.com/691206 Reviewed-by: enne <enne@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#505416} [modify] https://crrev.com/5d1be840afed203dee9425853a0a64b9d61cdd3b/cc/benchmarks/rasterize_and_record_benchmark_impl.cc [modify] https://crrev.com/5d1be840afed203dee9425853a0a64b9d61cdd3b/cc/raster/playback_image_provider.cc [modify] https://crrev.com/5d1be840afed203dee9425853a0a64b9d61cdd3b/cc/raster/playback_image_provider.h [modify] https://crrev.com/5d1be840afed203dee9425853a0a64b9d61cdd3b/cc/raster/playback_image_provider_unittest.cc [modify] https://crrev.com/5d1be840afed203dee9425853a0a64b9d61cdd3b/cc/tiles/tile_manager.cc
,
Oct 2 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 25 2017