"Request Debug Trace" doesn't work |
||||||
Issue description1- go to https://chromeperf.appspot.com/group_report?sid=f3891f29fce712f6e65fa3de0128a542bf45da8be1670aa2caaa2eb70914905a 2- click on the regression alert, click on the "REQUEST DEBUG TRACE" button 3- enter required information (e.g. "toplevel,gpu,cc,ipc,mojom" as trace filter string), click "SEND TO PERF TRY BOT" 4- wait for the try job to be created, click on the link, e.g. https://codereview.chromium.org/3018643002 5- observe the try job fails immediately with an exception. Note also the text 'Project "" does not have a commit queue.'
,
Sep 25 2017
Yeah, we should be able to get this back relatively easily, I think. Dashboard already communicates with Pinpoint, so we can kick off a perf try job instead of a bisect. The trace url is in the chartjson output, so we just need to surface that in the UI.
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/b9dc069a4752d711a475b196fec927dc749efd20 commit b9dc069a4752d711a475b196fec927dc749efd20 Author: Simon <simonhatch@chromium.org> Date: Thu Sep 28 17:41:30 2017 Dashboard - Add pinpoint-perf-job-dialog for perf try jobs. Dashboard initiates perf try jobs when you hit "request debug trace" via the chart tooltip. This adds a Pinpoint version of the trace dialog that routes the request to Pinpoint. Basically cloned the trace-form dialog into pinpoint-perf-job-dialog, and changed the internals to communicate with the /pinpoint endpoint. Should look and act exactly the same, with the exception that it will say "Send to Pinpoint". Bug: chromium:768530 Change-Id: I65d91824a1f73436460ee39e68ce54946d2b279b Reviewed-on: https://chromium-review.googlesource.com/688826 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> [add] https://crrev.com/b9dc069a4752d711a475b196fec927dc749efd20/dashboard/dashboard/static/pinpoint.html [modify] https://crrev.com/b9dc069a4752d711a475b196fec927dc749efd20/dashboard/dashboard/dispatcher.py [modify] https://crrev.com/b9dc069a4752d711a475b196fec927dc749efd20/dashboard/dashboard/pinpoint_request_test.py [modify] https://crrev.com/b9dc069a4752d711a475b196fec927dc749efd20/dashboard/dashboard/elements/pinpoint-job-dialog.html [modify] https://crrev.com/b9dc069a4752d711a475b196fec927dc749efd20/dashboard/dashboard/elements/trace-button.html [modify] https://crrev.com/b9dc069a4752d711a475b196fec927dc749efd20/dashboard/dashboard/elements/bisect-button.html [modify] https://crrev.com/b9dc069a4752d711a475b196fec927dc749efd20/dashboard/dashboard/pinpoint_request.py [add] https://crrev.com/b9dc069a4752d711a475b196fec927dc749efd20/dashboard/dashboard/elements/pinpoint-perf-job-dialog-test.html [add] https://crrev.com/b9dc069a4752d711a475b196fec927dc749efd20/dashboard/dashboard/elements/pinpoint-perf-job-dialog.html
,
Sep 28 2017
Next steps to finish this off are to support the extra params on Pinpoint's side, and surface the trace links.
,
Oct 17 2017
,
Oct 18 2017
,
Nov 14 2017
,
Dec 4 2017
All the traces are surfaced after https://github.com/catapult-project/catapult/issues/4048, so this should be fixed.
,
Dec 4 2017
I just tried to request a debug trace for the regression below, yet can't see whether a try job was kicked off for that - or how to retrieve the try job link. Is that expected? https://chromeperf.appspot.com/group_report?bug_id=771292
,
Dec 4 2017
Just noticed that the request try job box says "Only telemetry is supported at the moment." when I open it again after clicking "Send to Pinpoint". Reopening :)
,
Dec 4 2017
Ah, that would be a different bug then. Looks like the dialog should wait around for the result of submitting the job from the backend. I've just filed https://github.com/catapult-project/catapult/issues/4075 for that issue. This isn't a Pinpoint specific limitation, we can only configure the trace categories for telemetry tests and this isn't a telemetry test.
,
Dec 4 2017
I see, so there's no way of getting a trace out of this particular benchmark in any case? Feel free to close this then.
,
Dec 4 2017
I could be wrong but I don't think those binaries support getting a trace out, no.
,
Dec 4 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sullivan@chromium.org
, Sep 25 2017Owner: dtu@chromium.org