We aim to establish a model and connect it to the model via databinding.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a39bafec09576feb9c6258c1afcda050e3353873 commit a39bafec09576feb9c6258c1afcda050e3353873 Author: Ian Vollick <vollick@chromium.org> Date: Thu Sep 28 02:27:55 2017 [vr] Update the loading indicator via databinding This CL does a number of things. It introduces vr::Model, which is owned by vr::Ui. The model does not contain much yet (just a bit of state related to the loading indicator), but the goal is for it to house all our browser state). In order to have vr::Ui poke the model rather than having the BrowserUiInterface calls get routed directly to the UiSceneManager, I also made the vr::Ui implement both BrowserUiInterface and UiInterface. Given that we have rounded rects as a primitive, this change also allowed us to avoid using textures at all for the loading indicator. Bug: 768512 Change-Id: I2c5ff1bba6be7280aeadb53b000e0acb30fdc502 Reviewed-on: https://chromium-review.googlesource.com/682773 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#504872} [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/android/vr_shell/vr_shell_gl.h [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/BUILD.gn [delete] https://crrev.com/d38d873528abc1ce5876431652c75c7fd972a1dd/chrome/browser/vr/elements/loading_indicator.cc [delete] https://crrev.com/d38d873528abc1ce5876431652c75c7fd972a1dd/chrome/browser/vr/elements/loading_indicator.h [delete] https://crrev.com/d38d873528abc1ce5876431652c75c7fd972a1dd/chrome/browser/vr/elements/loading_indicator_texture.cc [delete] https://crrev.com/d38d873528abc1ce5876431652c75c7fd972a1dd/chrome/browser/vr/elements/loading_indicator_texture.h [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/elements/ui_element.h [add] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/model/model.h [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/test/ui_scene_manager_test.cc [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/test/ui_scene_manager_test.h [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/ui.cc [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/ui.h [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/ui_interface.h [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/ui_scene.cc [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/ui_scene_manager.h [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/ui_scene_manager_unittest.cc [modify] https://crrev.com/a39bafec09576feb9c6258c1afcda050e3353873/chrome/browser/vr/vr_shell_renderer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f35343ac3de89b67df19b1a00c21ac058fb98e0 commit 3f35343ac3de89b67df19b1a00c21ac058fb98e0 Author: Ian Vollick <vollick@chromium.org> Date: Thu Oct 12 20:06:30 2017 [vr] Introduce vector bindings In this CL we introduce a collection binding. The intent is to handle situations where the number of models is variable and corresponding views (and per-model bindings) need to be created/destroyed. Bug: 768512 Change-Id: I9444fdbf067d0ff031df8e863b84d934452eec67 Reviewed-on: https://chromium-review.googlesource.com/716516 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#508419} [modify] https://crrev.com/3f35343ac3de89b67df19b1a00c21ac058fb98e0/chrome/browser/vr/BUILD.gn [add] https://crrev.com/3f35343ac3de89b67df19b1a00c21ac058fb98e0/chrome/browser/vr/databinding/vector_binding.h [add] https://crrev.com/3f35343ac3de89b67df19b1a00c21ac058fb98e0/chrome/browser/vr/databinding/vector_binding_unittest.cc [add] https://crrev.com/3f35343ac3de89b67df19b1a00c21ac058fb98e0/chrome/browser/vr/databinding/vector_element_binding.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5cc802d725d4710f0cff3ac5189d177011d275a commit a5cc802d725d4710f0cff3ac5189d177011d275a Author: Ian Vollick <vollick@chromium.org> Date: Wed Nov 01 14:04:47 2017 [vr] Move the controller, laser, and reticle into the UiElement tree These elements were previously special-cased in UiRenderer. With this change, the elements are now included in the scene graph permitting some simplifications and making it easier to, for example, fade out the controller if desired. There should only be one functional change in this CL: we break reticle sorting. This is tracked by crbug.com/779692 . Bug: 774501 , 768512 ,776521 Change-Id: I5173b0a419a93abe324d496664bdafef933162a5 Reviewed-on: https://chromium-review.googlesource.com/744543 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#513120} [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/android/vr_shell/vr_controller.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/android/vr_shell/vr_controller.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/android/vr_shell/vr_shell_gl.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/BUILD.gn [rename] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/controller_mesh.cc [rename] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/controller_mesh.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/content_element.h [add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/controller.cc [add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/controller.h [add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/laser.cc [add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/laser.h [add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/reticle.cc [add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/reticle.h [add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/ui_element_name.h [add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/model/controller_model.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/model/model.h [add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/model/reticle_model.h [add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/model/web_vr_timeout_state.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/test/fake_ui_element_renderer.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/test/fake_ui_element_renderer.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/test/ui_pixel_test.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/testapp/vr_test_context.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_element_renderer.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_input_manager.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_input_manager.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_input_manager_unittest.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_interface.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_renderer.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_renderer.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_renderer_unittest.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_scene.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_scene.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_scene_manager.h [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/vr_shell_renderer.cc [modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/vr_shell_renderer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1389bea111044d9f4799f059fdc4926ede4fc9d commit d1389bea111044d9f4799f059fdc4926ede4fc9d Author: Ian Vollick <vollick@chromium.org> Date: Fri Nov 17 04:26:38 2017 [vr] Fade out 2d browsing elements when showing modal dialogs With this CL, I change how the visibility of modal dialogs and the related visibility of 2d browsing scene elements are managed. I have also added two elements in the ancestor chain for the audio permission prompt: a shadow and a full screen hit target (similar to the exit prompt backplane). Bug: 768512 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia5dcbe865fb8d92e90538039d9dfaa4679573dac Reviewed-on: https://chromium-review.googlesource.com/774908 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Yash Malik <ymalik@chromium.org> Reviewed-by: Biao She <bshe@chromium.org> Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#517298} [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/content_input_delegate.h [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/elements/exit_prompt.cc [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/elements/exit_prompt.h [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/elements/exit_prompt_unittest.cc [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/elements/ui_element_name.h [add] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/model/modal_prompt_type.cc [add] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/model/modal_prompt_type.h [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/model/model.h [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/test/fake_ui_element_renderer.cc [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/test/fake_ui_element_renderer.h [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/ui.cc [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/ui.h [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/ui_input_manager_unittest.cc [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/ui_renderer_unittest.cc [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/ui_scene_manager.h [modify] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/ui_scene_manager_unittest.cc [add] https://crrev.com/d1389bea111044d9f4799f059fdc4926ede4fc9d/chrome/browser/vr/ui_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0375ab866574fe00d8b316bd5d472b5e666c795e commit 0375ab866574fe00d8b316bd5d472b5e666c795e Author: Ian Vollick <vollick@chromium.org> Date: Mon Nov 20 19:58:05 2017 [vr] Wire up the system indicators via databinding With these CL the permission indicators have their colors and visibility determined by bindings to model properties. Bug: 768512 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4aff56e1a5e986ad11cb157f47b5e86a800c5084 Reviewed-on: https://chromium-review.googlesource.com/779240 Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517893} [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/android/vr_shell/vr_gl_thread.cc [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/android/vr_shell/vr_gl_thread.h [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/vr/browser_ui_interface.h [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/vr/model/model.h [add] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/vr/model/permissions_model.h [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/vr/testapp/vr_test_context.h [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/vr/ui.cc [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/vr/ui.h [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/vr/ui_scene_manager.h [modify] https://crrev.com/0375ab866574fe00d8b316bd5d472b5e666c795e/chrome/browser/vr/ui_scene_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8030c531bbec8598bbc29c38ec2ac51672119f2 commit f8030c531bbec8598bbc29c38ec2ac51672119f2 Author: Ian Vollick <vollick@chromium.org> Date: Wed Nov 22 17:14:14 2017 [vr] Convert all scene elements to update dynamically via databinding In this change, I've completed the migration towards databinding-based updates for the scene. This change will regress our toast behavior temporarily, but I intend to fix this in a follow up since it'll involve creating a stack of modes. crbug.com/787582 tracks this fix. Bug: 768512 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9900ca8c634a59fcecd022d11a4c2fe2f47c14b0 Reviewed-on: https://chromium-review.googlesource.com/780281 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#518663} [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/android/vr_shell/vr_gl_thread.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/android/vr_shell/vr_gl_thread.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/BUILD.gn [delete] https://crrev.com/b6397da22ea826f692c67867ff6d097b8d84b928/chrome/browser/vr/color_scheme.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/audio_permission_prompt.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/audio_permission_prompt.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/audio_permission_prompt_texture.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/audio_permission_prompt_texture.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/button.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/button.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/content_element.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/content_element.h [add] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/draw_phase.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/draw_phase.h [delete] https://crrev.com/b6397da22ea826f692c67867ff6d097b8d84b928/chrome/browser/vr/elements/exclusive_screen_toast.cc [delete] https://crrev.com/b6397da22ea826f692c67867ff6d097b8d84b928/chrome/browser/vr/elements/exclusive_screen_toast.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/exclusive_screen_toast_texture.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/exit_prompt.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/exit_prompt.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/exit_prompt_texture.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/exit_prompt_texture.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/exit_warning_texture.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/simple_textured_element.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/spinner.cc [delete] https://crrev.com/b6397da22ea826f692c67867ff6d097b8d84b928/chrome/browser/vr/elements/system_indicator.cc [delete] https://crrev.com/b6397da22ea826f692c67867ff6d097b8d84b928/chrome/browser/vr/elements/system_indicator.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/system_indicator_texture.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/system_indicator_texture.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/text.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/textured_element.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/textured_element.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/transient_element.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/transient_element.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/transient_element_unittest.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/ui_texture.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/ui_texture.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/url_bar.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/url_bar.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/url_bar_texture.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/url_bar_texture.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/url_bar_texture_unittest.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/vector_icon.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/elements/webvr_url_toast_texture.cc [add] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/model/color_scheme.cc [rename] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/model/color_scheme.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/model/model.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/model/model.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/test/mock_browser_interface.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/test/ui_scene_manager_test.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/test/ui_scene_manager_test.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/testapp/vr_test_context.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/ui.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/ui.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/ui_browser_interface.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/ui_input_manager_unittest.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/ui_scene.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/ui_scene.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/ui_scene_manager.h [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/ui_scene_manager_unittest.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/ui_scene_unittest.cc [modify] https://crrev.com/f8030c531bbec8598bbc29c38ec2ac51672119f2/chrome/browser/vr/ui_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Sep 28 2017