New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768509 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

touch_WakeupSource: fix for convertibles

Project Member Reported by briannorris@chromium.org, Sep 25 2017

Issue description

Since bug 620633, touch_WakeupSource is broken for convertibles. e.g.:

https://wmatrix.googleplex.com/platform/unfiltered?suites=bvt-perbuild&days_back=30&releases=tot&platforms=kevin&tests=touch_WakeupSource

Reason: "Touchpad is not a wake source!"

This test should accommodate the fact that convertibles no longer allow touchpad wakeup.
 

Comment 1 by derat@chromium.org, Sep 26 2017

Cc: derat@chromium.org
Owner: kathrelk...@chromium.org
Is there a process by which someone monitors whether this test is passing or failing? I believe that powerd's behavior changed more than five months ago.

The test appears to already have some code to accommodate convertible devices' behavior, added more than two years ago for issue 467746:

    # Devices whose touchpads should not be a wake source.
    _NO_TOUCHPAD_WAKE = ['clapper', 'glimmer', 'veyron_minnie']

Presumably it'd be possible to manually maintain a list of convertible devices there, but I'm not convinced that we'll get any value from doing so.
I do monitor this test for unexpected failures, but fixing that particular problem is lower priority right now.
Status: Assigned (was: Untriaged)

Sign in to add a comment