New issue
Advanced search Search tips

Issue 768494 link

Starred by 2 users
Status: Fixed
Owner:
vapier@chromium.org
Closed: Oct 2017
Cc:
bleung@chromium.org
derat@chromium.org
adlr@chromium.org
vapier@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

crash-reporter: kernel_log_collector.sh doesn't match anything

Project Member Reported by diand...@chromium.org, Sep 25 2017 
Forked from b/66684735

I took a quick peek at some of crash reports pointed to by b/66684735, all of which had the signature "crash_reporter-udev-collection-change--i2c-atmel_mxt_ts".  I saw a whole bunch of empty crash reports.  For instance, these reports: 466736012fdf3190, 5d99ac9e80c7deb5, ec7de150cf295f90, ...

The total contents of the log is: "END-OF-LOG"

It looks like this type of crash report (namely with a signature of "crash_reporter-udev-collection-change--i2c-atmel_mxt_ts") is supposed to have special handling.  That special handling was added in <https://gerrit.chromium.org/gerrit/48239>

...so it seems like something about the special handling is broken.  We should either fix it or remove the special handling.  As far as I can tell the author no longer works at Google, so not sure who to assign to.  Adding a spam of possible people who would know (sorry!)

Comment 1 by vapier@chromium.org, Oct 27 2017

Owner: vapier@chromium.org
Summary: crash-reporter: kernel_log_collector.sh doesn't match anything (was: crash_reporter-udev-collection-change--i2c-atmel_mxt_ts producing bogus crash reports)
kernel_log_collector.sh is sensitive to the syslog format.  it requires the leading format to be:
2013-06-14T16:31:40.514513-07:00 localhost kernel: [    2.682472] MSG MSG ...
2013-06-19T20:38:58.661826+00:00 localhost kernel: [    1.668092] MSG MSG ...

this broke when we changed the log format:
https://chromium-review.googlesource.com/212329 - remove "localhost" hostname
https://chromium-review.googlesource.com/238581 - add INFO/etc... severity lines

so the format now looks like:
2017-10-26T13:33:07.971874-07:00 WARNING kernel: [147836.200369] audit_printk_skb: 39 callbacks suppressed

i've posted a CL to fix this:
https://chromium-review.googlesource.com/741322

i don't think it's the right long term answer, but it fixes the existing code w/out making it worse (i.e. maintains status quo).

wrt "who do these crashes go to", they're all touchpad related, so to the touchpad guys rather than the specific person who added this special handling in the first place.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ecb994db686adda392b2c4e55242ce5235a0c5ea

commit ecb994db686adda392b2c4e55242ce5235a0c5ea
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Oct 27 23:14:07 2017

crash: fix kernel log collection after syslog format changes

When we updated the format of the syslog output, our grep logic here
stopped matching lines producing empty logs all the time.

BUG= chromium:768494 
TEST=`kernel_log_collector.sh audit 1000` displays lines again

Change-Id: Ib57be5c69828759660bb8a78b9552905982066d8
Reviewed-on: https://chromium-review.googlesource.com/741322
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/ecb994db686adda392b2c4e55242ce5235a0c5ea/crash-reporter/kernel_log_collector.sh

Comment 3 by vapier@chromium.org, Oct 27 2017

Status: Fixed (was: Untriaged)
considering how long this has been broken, i'm not sure it's worth backporting (especially since M63 is in beta now)

feel free to re-open if anyone feels differently

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment