Clean up obsolete paths in chromite/lib/chrome_util.py |
||
Issue description
I noticed chromite/lib/chrome_util.py has references to files that no longer exists. I'm not sure how much backwards compatibility chrome_util.py needs, but certainly with Chromium as this writing, some of these files no longer exists:
# Merged into chrome binary
Path('libpdf.so', exe=True, optional=True)
# No longer exists. Not sure what happened.
Path('libppGoogleNaClPluginChrome.so',
exe=True,
cond=C.GnSetTo(_ENABLE_NACL, True),
optional=True),
# No longer exists. Not sure what happened.
Path('libffmpegsumo.so', exe=True, optional=True)
And some may be (soon) obsolete:
# Exists in build dirs but not shipped on Linux at least.
Path('nacl_helper_nonsfi',
exe=True,
optional=True,
cond=C.GnSetTo(_ENABLE_NACL, True)),
# Exists in build dirs but not shipped on Linux at least.
# PNaCl is in the process of being deprecated.
Path('pnacl/', cond=C.GnSetTo(_ENABLE_NACL, True))
,
Dec 11 2017
Getting the low hanging fruits: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/820623 I don't actually know the state of sandboxing on ChromeOS. Does ChromeOS still need the setuid chrome_sandbox binary? Also, can someone remind me what this file list actually does? https://chromium-review.googlesource.com/c/chromium/src/+/812587 is trying to unship snapshot_blob.bin, with v8_snapshot_blob.bin as the replacement. Yet v8_snapshot_blob.bin is not on the list...
,
Dec 12 2017
i think CrOS no longer needs a set*id sandbox binary ... the oldest kernel we support is linux-3.8 which should have all the linux namespaces available
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/244d72f66b5bb3da19266c54093d9cfcf04c6590 commit 244d72f66b5bb3da19266c54093d9cfcf04c6590 Author: Lei Zhang <thestig@google.com> Date: Tue Dec 12 21:51:02 2017 Remove some obsolete paths from lib/chrome_util.py. These are clearly obsolete. BUG=chromium:768491 Change-Id: I19507c23e75fdc6a73d619675517cc173c99f91d Reviewed-on: https://chromium-review.googlesource.com/820623 Commit-Ready: Lei Zhang <thestig@chromium.org> Tested-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/244d72f66b5bb3da19266c54093d9cfcf04c6590/lib/chrome_util.py
,
Mar 2 2018
Is this done?
,
Mar 2 2018
Probably not. I only deleted a few entries that I know are obsolete. |
||
►
Sign in to add a comment |
||
Comment 1 by vapier@chromium.org
, Sep 25 2017