New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768479 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Racing reverts could result in an empty commit

Project Member Reported by st...@chromium.org, Sep 25 2017

Issue description

For a few times, I've spotted such cases like the example below: two separate reverts of the same culprit were created & CQed around the same time, and the one landed later had no changed files after a rebase.

Culprit: https://chromium-review.googlesource.com/c/chromium/src/+/677202
revert1 landed first: https://chromium-review.googlesource.com/c/chromium/src/+/677224
revert2 landed later and it had no changed files after a rebase: https://chromium-review.googlesource.com/c/chromium/src/+/677244

It would be great if we could avoid empty commits like the revert2 above.
Just wondering whether commit-bot could do a rebase and check for changed files before landing the CL.
However, it is more reliable to do this check on Gerrit side though.

(If Findit's auto-revert is turned on, it might run into the same issue if Sheriffs create separate reverts.)
 

Comment 1 by st...@chromium.org, Sep 25 2017

Cc: chanli@chromium.org robert...@chromium.org
Yep, KI. Let me dedup this.
Mergedinto: 735839
Status: Duplicate (was: Untriaged)

Sign in to add a comment