New issue
Advanced search Search tips

Issue 768477 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add pc files for puffin

Project Member Reported by ahass...@chromium.org, Sep 25 2017

Issue description

Puffin does not have pc files for its two libraries. Add pc files for them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/puffin/+/1d5d73bc5d7cf9f5f01a5a59beaabb36e664f8e1

commit 1d5d73bc5d7cf9f5f01a5a59beaabb36e664f8e1
Author: Amin Hassani <ahassani@google.com>
Date: Tue Sep 26 23:14:06 2017

puffin: Add pc files

Adds files libpuffindiff.pc and libpuffpatch.pc.

BUG= chromium:768477 
TEST=emerged and make sure pc files are copied.

Change-Id: I2bacfdf847a363c138c601a42fd6c305549bba49
Reviewed-on: https://chromium-review.googlesource.com/683595
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/1d5d73bc5d7cf9f5f01a5a59beaabb36e664f8e1/libpuffdiff.pc
[add] https://crrev.com/1d5d73bc5d7cf9f5f01a5a59beaabb36e664f8e1/libpuffpatch.pc

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d55c6e386938dba7cdff590c4b3488e55f10fd09

commit d55c6e386938dba7cdff590c4b3488e55f10fd09
Author: Amin Hassani <ahassani@google.com>
Date: Tue Sep 26 23:14:07 2017

puffin: Add pc files

Adds libpuffdiff.pc and libpuffpatch.pc files for puffin.

BUG= chromium:768477 
TEST=emerged and checked the pc files are copied.
CQ-DEPEND=CL:683595

Change-Id: I1b0039ed840a9074fcc472c33b5cbf20991c2a58
Reviewed-on: https://chromium-review.googlesource.com/683754
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d55c6e386938dba7cdff590c4b3488e55f10fd09/dev-util/puffin/puffin-9999.ebuild

Status: Verified (was: Started)

Sign in to add a comment