New issue
Advanced search Search tips

Issue 768461 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 696813



Sign in to add a comment

Fix puffin binary to be used in python scripts

Project Member Reported by ahass...@chromium.org, Sep 25 2017

Issue description

Add functionality in python scripts in update_payload to be able to use puffin binary. This tests are needed for canary builds.
 
Blocking: 696813
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/864c20bfbd6c2cacb3bf4e9688106a7c9bcf7233

commit 864c20bfbd6c2cacb3bf4e9688106a7c9bcf7233
Author: Amin Hassani <ahassani@google.com>
Date: Sun Oct 22 06:47:36 2017

generate_au_zip: Add puffin

Adds puffin binary to generate_au_zip.

BUG= chromium:768461 
TEST=tryjob

Change-Id: Iadc11d7cdf262b28366552b8de60be58a2f9c06d
Reviewed-on: https://chromium-review.googlesource.com/682594
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/864c20bfbd6c2cacb3bf4e9688106a7c9bcf7233/build_library/generate_au_zip.py

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/8ad22ba0765dc6351bfd59da8c43e06476b56c01

commit 8ad22ba0765dc6351bfd59da8c43e06476b56c01
Author: Amin Hassani <ahassani@google.com>
Date: Tue Oct 24 22:30:13 2017

update_payload: Add zero operation support

Currenlty the applier.py and checker.py does not support ZERO
operation. This patch adds support for it. In addition, when generating
ZERO operation, we were not clearing the source length and extent
properties out of the protobuf. ZERO operation has no source length or
extent.

BUG= chromium:768461 
TEST=unittest pass; scripts/paycheck.py --check payload.delta;

Change-Id: I766deaca4380686797893c2686036d59525546f4
Reviewed-on: https://chromium-review.googlesource.com/713539
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>

[modify] https://crrev.com/8ad22ba0765dc6351bfd59da8c43e06476b56c01/scripts/update_payload/checker_unittest.py
[modify] https://crrev.com/8ad22ba0765dc6351bfd59da8c43e06476b56c01/scripts/update_payload/applier.py
[modify] https://crrev.com/8ad22ba0765dc6351bfd59da8c43e06476b56c01/scripts/update_payload/checker.py

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/puffin/+/27574e9e83eaefe241efe97c482f1f3e05c6f219

commit 27574e9e83eaefe241efe97c482f1f3e05c6f219
Author: Amin Hassani <ahassani@google.com>
Date: Thu Oct 26 04:59:07 2017

puffin: Add ExtentStream

We need some sort of extent stream for the update payload tests in
update_engine. These scripts are run as a part of canary builds. This CL
adds a new class ExtentStream that is only used in main.cc for applying
patches. This class should not be shipped to the client devices as part
of puffpatch nor it needs to be in puffdiff.

BUG= chromium:768461 
TEST=unittest pass;

Change-Id: Ic482be8e9b6b7e7f12f5f796de1d96d57275097b
Reviewed-on: https://chromium-review.googlesource.com/714453
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>

[modify] https://crrev.com/27574e9e83eaefe241efe97c482f1f3e05c6f219/puffin.gyp
[modify] https://crrev.com/27574e9e83eaefe241efe97c482f1f3e05c6f219/src/main.cc
[add] https://crrev.com/27574e9e83eaefe241efe97c482f1f3e05c6f219/src/extent_stream.cc
[modify] https://crrev.com/27574e9e83eaefe241efe97c482f1f3e05c6f219/Makefile
[add] https://crrev.com/27574e9e83eaefe241efe97c482f1f3e05c6f219/src/extent_stream.h
[modify] https://crrev.com/27574e9e83eaefe241efe97c482f1f3e05c6f219/src/stream_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/cdeb6e60ad4837afff97a370b6ea39dc98146a36

commit cdeb6e60ad4837afff97a370b6ea39dc98146a36
Author: Amin Hassani <ahassani@google.com>
Date: Wed Nov 01 00:31:03 2017

update_payload: Add puffdiff support.

This patch adds support for applier.py to be able to apply PUFFDIFF
operation using puffin binary. It also fixes minor deficiencies for the
PUFFDIFF operation.

BUG= chromium:768461 
TEST=unittests pass;
TEST=scripts/paycheck.py payload-puffin.delta new_kern.dat new_root.dat old_kern.dat old_root.dat

Change-Id: I5612ead8d8b8176e7263cfcb15403e8d36319642
Reviewed-on: https://chromium-review.googlesource.com/713540
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>

[modify] https://crrev.com/cdeb6e60ad4837afff97a370b6ea39dc98146a36/update_metadata.proto
[modify] https://crrev.com/cdeb6e60ad4837afff97a370b6ea39dc98146a36/scripts/update_payload/checker_unittest.py
[modify] https://crrev.com/cdeb6e60ad4837afff97a370b6ea39dc98146a36/scripts/update_payload/applier.py

Status: Fixed (was: Started)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment