New issue
Advanced search Search tips

Issue 768449 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Chrome OS: Clicking checkbox and radio menu item icons does nothing.

Project Member Reported by msw@chromium.org, Sep 25 2017

Issue description

Chrome OS: Clicking checkbox and radio menu item icons does nothing.

On ChromeOS ToT #503942
(1) Open the shelf/desktop context menu
(2) Hover over the "Shelf position" item.
(3) Attempt to click the center of any radio circle icon.

Ditto for the checkbox icon when the item is checked:
(1) Open the shelf/desktop context menu.
(2) Select the [unchecked] "Autohide shelf" item (to make it checked).
(3) Open the shelf/desktop context menu again.
(4) Attempt to click the center of the checkmark icon.

Expected: Clicking the icon of the menu item executes the menu command.
Actual: Clicking a menu item icon does nothing and the menu stays open.

This doesn't seem to repro on Linux, perhaps we use a system menu?
This probably repros on Windows, but I haven't tested it myself.

I'll take a quick look, I bet it's an easy fix. (set_can_process_events_within_subtree)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09c2eddf96046d0719aab2098ace8ec4b5d4f042

commit 09c2eddf96046d0719aab2098ace8ec4b5d4f042
Author: Mike Wasserman <msw@chromium.org>
Date: Fri Sep 29 17:20:53 2017

views: Make the radio or check in MenuItemView clickable.

Make the menu item handle click events on its icon view.
(support clicking on a radio/check icon in a menu item)

Bug:  768449 
Test: See bug.
Change-Id: I1da3ce9baad36b1e35278e3a7c466e96c4e00876
Reviewed-on: https://chromium-review.googlesource.com/691175
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505402}
[modify] https://crrev.com/09c2eddf96046d0719aab2098ace8ec4b5d4f042/ui/views/controls/menu/menu_item_view.cc

Comment 2 by msw@chromium.org, Sep 29 2017

Status: Fixed (was: Assigned)

Sign in to add a comment