New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768419 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Feature

Blocked on:
issue 761994



Sign in to add a comment

Test Doodle integration on Local NTP

Project Member Reported by sfiera@chromium.org, Sep 25 2017

Issue description

A feature is only as good as its tests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/deaa07bec5d105ffc546d37eba3da4cba341fc03

commit deaa07bec5d105ffc546d37eba3da4cba341fc03
Author: Chris Pickel <sfiera@chromium.org>
Date: Fri Sep 29 15:13:41 2017

Local NTP: add smoke tests for doodles

Split LogoService into LogoService interface and LogoServiceImpl to make
it easier to provide fake data to the test.

Bug:  768419 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84639189d2db1b24a2e139936c99369352bab587
Reviewed-on: https://chromium-review.googlesource.com/690198
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505374}
[modify] https://crrev.com/deaa07bec5d105ffc546d37eba3da4cba341fc03/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/deaa07bec5d105ffc546d37eba3da4cba341fc03/chrome/browser/search_provider_logos/logo_service_factory.cc
[modify] https://crrev.com/deaa07bec5d105ffc546d37eba3da4cba341fc03/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/deaa07bec5d105ffc546d37eba3da4cba341fc03/components/search_provider_logos/BUILD.gn
[modify] https://crrev.com/deaa07bec5d105ffc546d37eba3da4cba341fc03/components/search_provider_logos/logo_service.cc
[modify] https://crrev.com/deaa07bec5d105ffc546d37eba3da4cba341fc03/components/search_provider_logos/logo_service.h
[add] https://crrev.com/deaa07bec5d105ffc546d37eba3da4cba341fc03/components/search_provider_logos/logo_service_impl.cc
[add] https://crrev.com/deaa07bec5d105ffc546d37eba3da4cba341fc03/components/search_provider_logos/logo_service_impl.h
[rename] https://crrev.com/deaa07bec5d105ffc546d37eba3da4cba341fc03/components/search_provider_logos/logo_service_impl_unittest.cc
[modify] https://crrev.com/deaa07bec5d105ffc546d37eba3da4cba341fc03/ios/chrome/browser/google/google_logo_service.h
[modify] https://crrev.com/deaa07bec5d105ffc546d37eba3da4cba341fc03/ios/chrome/browser/google/google_logo_service.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/014d7bf536de5c48c1d5901b99ffb606e027b4a9

commit 014d7bf536de5c48c1d5901b99ffb606e027b4a9
Author: Chris Pickel <sfiera@chromium.org>
Date: Wed Oct 04 16:46:08 2017

NTP Doodles: add test for fade-in

Bug:  768419 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9f5f2b134213de42e241ba7aa16a8026d77e6684
Reviewed-on: https://chromium-review.googlesource.com/695209
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506413}
[modify] https://crrev.com/014d7bf536de5c48c1d5901b99ffb606e027b4a9/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/014d7bf536de5c48c1d5901b99ffb606e027b4a9/chrome/browser/ui/search/local_ntp_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6f47fd27c1fef5a9f1becc97a29e8968add819e

commit a6f47fd27c1fef5a9f1becc97a29e8968add819e
Author: Chris Pickel <sfiera@chromium.org>
Date: Fri Oct 06 09:40:17 2017

Local NTP: more doodle tests

Test different fading scenarios, and animated CTA.

Bug:  768419 
Change-Id: I390db6f554a5184ade6092e5353a210c0e18d5e4
Reviewed-on: https://chromium-review.googlesource.com/702485
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507018}
[modify] https://crrev.com/a6f47fd27c1fef5a9f1becc97a29e8968add819e/chrome/browser/ui/search/local_ntp_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0592e9da41f6f5304abf2ca3b4a926a0dece6cf9

commit 0592e9da41f6f5304abf2ca3b4a926a0dece6cf9
Author: Marc Treib <treib@chromium.org>
Date: Fri Oct 06 12:04:39 2017

Local NTP Doodles: Add metrics tests

Bug:  768419 
Change-Id: I59c15d8a6030add94bf761eb5b0994c832e25147
Reviewed-on: https://chromium-review.googlesource.com/704774
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507035}
[modify] https://crrev.com/0592e9da41f6f5304abf2ca3b4a926a0dece6cf9/chrome/browser/ui/search/local_ntp_browsertest.cc

Comment 5 by mastiz@chromium.org, Oct 24 2017

sfiera@: friendly ping, can we mark this as fixed? Alternatively update the target milestone.

Comment 6 by sfiera@chromium.org, Oct 25 2017

Labels: -M-63 M-64
64 for interactives.
Blockedon: 761994
Labels: -M-64 M-65
Triage ping: Will there be more tests?
Also moving this to M65 as I don't believe anyone would merge tests ...

Comment 9 by sfiera@chromium.org, Dec 14 2017

Yes, there are still tests coming.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57976780bacc5089d24b93ab6000db42b26e19cb

commit 57976780bacc5089d24b93ab6000db42b26e19cb
Author: Chris Pickel <sfiera@chromium.org>
Date: Wed Jan 17 11:23:15 2018

Local NTP: test top edge of fakebox

It should always be the same, regardless of the doodle being shown.

Bug:  768419 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I421313173156ff6af05b8c3b7e0c911efbffc63f
Reviewed-on: https://chromium-review.googlesource.com/867045
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529708}
[modify] https://crrev.com/57976780bacc5089d24b93ab6000db42b26e19cb/chrome/browser/resources/local_ntp/local_ntp.css
[modify] https://crrev.com/57976780bacc5089d24b93ab6000db42b26e19cb/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/57976780bacc5089d24b93ab6000db42b26e19cb/chrome/browser/ui/search/local_ntp_doodle_browsertest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e6ca45147e2800ba4de234064edbadf192c8919

commit 7e6ca45147e2800ba4de234064edbadf192c8919
Author: Chris Pickel <sfiera@chromium.org>
Date: Wed Jan 17 18:23:21 2018

Local NTP: add test of resizeDoodle

R=treib

Bug:  768419 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I96caab431a75752934d2ed750f294ee8614bb12e
Reviewed-on: https://chromium-review.googlesource.com/870835
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529813}
[modify] https://crrev.com/7e6ca45147e2800ba4de234064edbadf192c8919/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/7e6ca45147e2800ba4de234064edbadf192c8919/chrome/browser/ui/search/local_ntp_doodle_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment