Test Doodle integration on Local NTP |
|||||
Issue descriptionA feature is only as good as its tests.
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/014d7bf536de5c48c1d5901b99ffb606e027b4a9 commit 014d7bf536de5c48c1d5901b99ffb606e027b4a9 Author: Chris Pickel <sfiera@chromium.org> Date: Wed Oct 04 16:46:08 2017 NTP Doodles: add test for fade-in Bug: 768419 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9f5f2b134213de42e241ba7aa16a8026d77e6684 Reviewed-on: https://chromium-review.googlesource.com/695209 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#506413} [modify] https://crrev.com/014d7bf536de5c48c1d5901b99ffb606e027b4a9/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/014d7bf536de5c48c1d5901b99ffb606e027b4a9/chrome/browser/ui/search/local_ntp_browsertest.cc
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6f47fd27c1fef5a9f1becc97a29e8968add819e commit a6f47fd27c1fef5a9f1becc97a29e8968add819e Author: Chris Pickel <sfiera@chromium.org> Date: Fri Oct 06 09:40:17 2017 Local NTP: more doodle tests Test different fading scenarios, and animated CTA. Bug: 768419 Change-Id: I390db6f554a5184ade6092e5353a210c0e18d5e4 Reviewed-on: https://chromium-review.googlesource.com/702485 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#507018} [modify] https://crrev.com/a6f47fd27c1fef5a9f1becc97a29e8968add819e/chrome/browser/ui/search/local_ntp_browsertest.cc
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0592e9da41f6f5304abf2ca3b4a926a0dece6cf9 commit 0592e9da41f6f5304abf2ca3b4a926a0dece6cf9 Author: Marc Treib <treib@chromium.org> Date: Fri Oct 06 12:04:39 2017 Local NTP Doodles: Add metrics tests Bug: 768419 Change-Id: I59c15d8a6030add94bf761eb5b0994c832e25147 Reviewed-on: https://chromium-review.googlesource.com/704774 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#507035} [modify] https://crrev.com/0592e9da41f6f5304abf2ca3b4a926a0dece6cf9/chrome/browser/ui/search/local_ntp_browsertest.cc
,
Oct 24 2017
sfiera@: friendly ping, can we mark this as fixed? Alternatively update the target milestone.
,
Oct 25 2017
64 for interactives.
,
Dec 5 2017
,
Dec 14 2017
Triage ping: Will there be more tests? Also moving this to M65 as I don't believe anyone would merge tests ...
,
Dec 14 2017
Yes, there are still tests coming.
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57976780bacc5089d24b93ab6000db42b26e19cb commit 57976780bacc5089d24b93ab6000db42b26e19cb Author: Chris Pickel <sfiera@chromium.org> Date: Wed Jan 17 11:23:15 2018 Local NTP: test top edge of fakebox It should always be the same, regardless of the doodle being shown. Bug: 768419 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I421313173156ff6af05b8c3b7e0c911efbffc63f Reviewed-on: https://chromium-review.googlesource.com/867045 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#529708} [modify] https://crrev.com/57976780bacc5089d24b93ab6000db42b26e19cb/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/57976780bacc5089d24b93ab6000db42b26e19cb/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/57976780bacc5089d24b93ab6000db42b26e19cb/chrome/browser/ui/search/local_ntp_doodle_browsertest.cc
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e6ca45147e2800ba4de234064edbadf192c8919 commit 7e6ca45147e2800ba4de234064edbadf192c8919 Author: Chris Pickel <sfiera@chromium.org> Date: Wed Jan 17 18:23:21 2018 Local NTP: add test of resizeDoodle R=treib Bug: 768419 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I96caab431a75752934d2ed750f294ee8614bb12e Reviewed-on: https://chromium-review.googlesource.com/870835 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#529813} [modify] https://crrev.com/7e6ca45147e2800ba4de234064edbadf192c8919/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/7e6ca45147e2800ba4de234064edbadf192c8919/chrome/browser/ui/search/local_ntp_doodle_browsertest.cc
,
Jan 18 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 29 2017