New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768411 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 3
Type: Feature



Sign in to add a comment

Opus is not compiled with neon optimizations on arm64

Project Member Reported by kthelgason@chromium.org, Sep 25 2017

Issue description

We are leaving significant performance on the table on most high-end mobile devices.

 
Cc: minyue@chromium.org magjed@chromium.org
Cc: henrika@chromium.org
Cc: tlegrand@chromium.org hlundin@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d1eff2dfed69690c4a6f312d54cb92c15e516f7

commit 9d1eff2dfed69690c4a6f312d54cb92c15e516f7
Author: Kári Tristan Helgason <kthelgason@chromium.org>
Date: Mon Oct 16 15:56:32 2017

Compile opus w/ neon intrinsics on arm64.

This results in significant speedups on those devices.

Bug:  768411 
Change-Id: I9ece6f14803489b854f6551d0136b407bb006ee7
Reviewed-on: https://chromium-review.googlesource.com/681703
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Kári Tristan Helgason <kthelgason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509063}
[modify] https://crrev.com/9d1eff2dfed69690c4a6f312d54cb92c15e516f7/third_party/opus/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6598a63c48a1f203dee48d6a351b112add90fa1

commit e6598a63c48a1f203dee48d6a351b112add90fa1
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Oct 17 21:29:47 2017

fuchsia: Exclude fuchsia from ARM optimizations for now

Currently fails to compile when using neon opts on Fuchsia. Disable for
now, since the ARM64 port is just trying to get to the linking/prototype
stage.

Bug:  768411 ,  775272 
Change-Id: I7adfa8dd97badb1f20ba38b36b5e438e9a7b1ede
Reviewed-on: https://chromium-review.googlesource.com/722262
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509541}
[modify] https://crrev.com/e6598a63c48a1f203dee48d6a351b112add90fa1/third_party/opus/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment