Text shadow doesn't work when printing
Reported by
o...@hindsiteinc.com,
Sep 25 2017
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.91 Safari/537.36 Steps to reproduce the problem: 1. Create an html file with some text and apply text-shadow css 2. Try to print 3. What is the expected behavior? Be able to see the text shadow in the printed version What went wrong? Text appears plain without the shadow Did this work before? N/A Chrome version: 61.0.3163.91 Channel: n/a OS Version: OS X 10.11.6 Flash Version:
,
Sep 25 2017
,
Sep 25 2017
Adding Blink>Paint to see if anyone on the Blink side can tell us if its asking Skia to render the shadows when printing. If Blink is trying to render the shadows, then this probably should be forwarded to Internals>Skia>PDF.
,
Sep 26 2017
I initially thought this was a duplicate, but according to Omaha the patch to re-enable shadow printing landed in 61.0.3135.0, so should be enabled in the reported version. fmalita@, scroggo@, are pdf text shadows a different issue than box shadows?
,
Sep 26 2017
Blink disables text shadows explicitly when printing: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/TextPainterBase.cpp?rcl=6cb262dd1ed0aaef6076911b7d672a6303a29548&l=147 Due to issue 258321 . I'll looking into getting rid of that.
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28c9c9928729e611dca1a9503cb10529793af2fb commit 28c9c9928729e611dca1a9503cb10529793af2fb Author: Florin Malita <fmalita@chromium.org> Date: Wed Sep 27 02:55:07 2017 Enable printing of text shadows Text shadows are currently disabled when printing, as a workaround for https://crbug.com/258321 . But that old regression is likely no longer relevant, and suppressing text shadows when printing is not desirable in general. BUG= 768397 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I511cdd19da249049ac9843377f5620088b413d6b Reviewed-on: https://chromium-review.googlesource.com/684856 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#504559} [add] https://crrev.com/28c9c9928729e611dca1a9503cb10529793af2fb/third_party/WebKit/LayoutTests/paint/printing/print-text-shadow.html [add] https://crrev.com/28c9c9928729e611dca1a9503cb10529793af2fb/third_party/WebKit/LayoutTests/platform/linux/paint/printing/print-text-shadow-expected.png [add] https://crrev.com/28c9c9928729e611dca1a9503cb10529793af2fb/third_party/WebKit/LayoutTests/platform/linux/paint/printing/print-text-shadow-expected.txt [add] https://crrev.com/28c9c9928729e611dca1a9503cb10529793af2fb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/printing/print-text-shadow-expected.png [add] https://crrev.com/28c9c9928729e611dca1a9503cb10529793af2fb/third_party/WebKit/LayoutTests/platform/mac/paint/printing/print-text-shadow-expected.png [add] https://crrev.com/28c9c9928729e611dca1a9503cb10529793af2fb/third_party/WebKit/LayoutTests/platform/mac/paint/printing/print-text-shadow-expected.txt [add] https://crrev.com/28c9c9928729e611dca1a9503cb10529793af2fb/third_party/WebKit/LayoutTests/platform/win/paint/printing/print-text-shadow-expected.png [add] https://crrev.com/28c9c9928729e611dca1a9503cb10529793af2fb/third_party/WebKit/LayoutTests/platform/win/paint/printing/print-text-shadow-expected.txt [add] https://crrev.com/28c9c9928729e611dca1a9503cb10529793af2fb/third_party/WebKit/LayoutTests/platform/win7/paint/printing/print-text-shadow-expected.png [modify] https://crrev.com/28c9c9928729e611dca1a9503cb10529793af2fb/third_party/WebKit/Source/core/paint/TextPainterBase.cpp
,
Sep 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ligim...@chromium.org
, Sep 25 2017