New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768387 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Payments-Maintenance


Sign in to add a comment

In PR editors, the done button should be disabled until all required fields are specified and valid.

Project Member Reported by mahmadi@chromium.org, Sep 25 2017

Issue description

The done button in the card/address/contact editor should be disabled until all of the required elements are specified and valid.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccb5393c9cc9cf58397674775f48fedc1650a93a

commit ccb5393c9cc9cf58397674775f48fedc1650a93a
Author: Marc-Antoine Courteau <macourteau@chromium.org>
Date: Thu Oct 05 14:04:25 2017

[Payment Request] Enable the done button only when all fields validate.

Also, behave the same was as on desktop, showing validation error
messages in real-time as fields are edited, once they are no longer
pristine (i.e., the user has entered and exited the field already).

Bug:  768387 
Change-Id: I4d8cf605e0e79422e31ca1fc5eda7a9e4161545a
Reviewed-on: https://chromium-review.googlesource.com/698905
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506717}
[modify] https://crrev.com/ccb5393c9cc9cf58397674775f48fedc1650a93a/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
[modify] https://crrev.com/ccb5393c9cc9cf58397674775f48fedc1650a93a/ios/chrome/browser/ui/payments/payment_request_editor_field.h
[modify] https://crrev.com/ccb5393c9cc9cf58397674775f48fedc1650a93a/ios/chrome/browser/ui/payments/payment_request_editor_field.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on :

App Version: 63.0.3237.0 canary
Devices : iPhone 7 Plus, iPad Air
iOS Versions: 10.3.3, 11.0

On 'Add Address', 'Add Card'&'Add Contact Info' editors, 'DONE' button will be disabled until all required fields are filled in.

Could test scenarios tapping on 'Incomplete Shipping Address' & 'Incomplete Google Payments cards'editors as the app is crashing (http://crbug.com/767404). 

These cases will be covered once the issue (http://crbug.com/767404) is fixed.

Marking this Bug as 'Verified' for now.



Sign in to add a comment