New issue
Advanced search Search tips

Issue 768386 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task


Show other hotlists

Hotlists containing this issue:
Payments-Maintenance


Sign in to add a comment

In PR editors, put the focus on the first field with a missing value

Project Member Reported by mahmadi@chromium.org, Sep 25 2017

Issue description

If the card/address/contact editor was opened after a touch on an incomplete card, populate the existing values in the appropriate fields and put the focus on the first field with a missing value.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5dd66a16c3fd0cad25a80a3a775d8409c8876d2

commit a5dd66a16c3fd0cad25a80a3a775d8409c8876d2
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Tue Oct 03 20:32:23 2017

[PR] Editor - Gives the first invalid editor field focus.

Initially validates the editor fields when an address or credit card is
being edited and modifies the validation method so that it attempts to give
the first invalid field it encounters focus, if possible, which is when the
field is a textfield.

Bug:  768386 
Change-Id: Ibc1df68f62351a25c2b10e6c392573ceaeab268d
Reviewed-on: https://chromium-review.googlesource.com/698356
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Reviewed-by: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506158}
[modify] https://crrev.com/a5dd66a16c3fd0cad25a80a3a775d8409c8876d2/ios/chrome/browser/ui/payments/address_edit_coordinator.mm
[modify] https://crrev.com/a5dd66a16c3fd0cad25a80a3a775d8409c8876d2/ios/chrome/browser/ui/payments/credit_card_edit_coordinator.mm
[modify] https://crrev.com/a5dd66a16c3fd0cad25a80a3a775d8409c8876d2/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.h
[modify] https://crrev.com/a5dd66a16c3fd0cad25a80a3a775d8409c8876d2/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment