New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 768368 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Sep 2017
Cc:
█ martiw@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Bookmarks "navigate back" gesture does not work the second time

Project Member Reported by gambard@chromium.org, Sep 25 2017 
Chrome Version: M63

What steps will reproduce the problem?
(1) Enable new UI for bookmarks
(2) Open bookmarks
(3) Navigate to Mobile Bookmarks
(4) Navigate to a folder inside Mobile Bookmarks
(5) Navigate back using a left to right swipe
(6) Navigate back once more using a left to right swipe

What is the expected result?
The first screen (displayed in 2.) should be presented.

What happens instead?
The swipe in 6. does not work.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95e7a1505a7ff5f02b534a341e90641ab64aa16a

commit 95e7a1505a7ff5f02b534a341e90641ab64aa16a
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Sep 25 16:01:42 2017

Fix "Navigate back" gesture on bookmarks

The navigate back gesture was broken on bookmarks because opening a new
folder removed the delegate of the gesture recognizer, preventing the
gesture to be triggered.
This CL fixes it by resetting the delegate to the ViewController when
the view is shown.

Bug: 768339, 768368 
Change-Id: I428bb2838ad7dc1d88d5aa1e21ee74e73493c638
Reviewed-on: https://chromium-review.googlesource.com/681702
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504072}
[modify] https://crrev.com/95e7a1505a7ff5f02b534a341e90641ab64aa16a/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/95e7a1505a7ff5f02b534a341e90641ab64aa16a/ios/chrome/browser/ui/bookmarks/bookmarks_new_generation_egtest.mm

Comment 2 by gambard@chromium.org, Sep 25 2017

Status: Fixed (was: Assigned)

Comment 3 by vbarig...@chromium.org, Oct 6 2017

Status: Verified (was: Fixed)
Verified on latest chrome canary version 63.0.3234.0 on iPhone 8 plus with iOS 11.0, iPhone 6 plus with iOS 10.3.3.  At step 6, Bookmarks screen is displayed.  Looks good.
►

Sign in to add a comment