New issue
Advanced search Search tips

Issue 768338 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

src/build dependency on src/testing makes DEPS pulling harder for subprojects

Project Member Reported by machenb...@chromium.org, Sep 25 2017

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/671369 added a depency from src/build to src/testing. The dependency was probably there before, but this change bubbled up into building v8 and blocks the deps roll, e.g.:
https://chromium-review.googlesource.com/c/v8/v8/+/677977

How should we structure dependencies across projects from now on? Some thoughts:

1) Have all build config files to be under src/build and maybe enforce this with a PRESUBMIT check in the future (maybe allow whitelisting exceptions to this?).
2) Make subprojects like V8 pull all other required directories except src/build as dependencies.
3) Let subprojects fork the required files from other directories.

Other ideas?

1) Would be easiest for subproject maintainers like me. I dislike 2) if the directories are large file graveyards with tons of things the subprojects actually don't need. 3) can server as short-term workaround, but essentially gathers technical dept.
 

Comment 1 by brat...@opera.com, Sep 25 2017

Maybe if the jumbo_test template moves to src/testing instead?

I can make such a CL and see if that is more natural.
Status: Fixed (was: Untriaged)
//build shouldn't depend on //test, so we need to come up with a different approach. The change has been reverted in the meantime.

Sign in to add a comment