Issue metadata
Sign in to add a comment
|
GLHelper scaling work regressed Mac only, causing a 3.2% regression in performance_browser_tests at 503521:503617 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 25 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8967482512088277568
,
Sep 25 2017
=== Auto-CCing suspected CL author miu@chromium.org === Hi miu@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Yuri Wiitala Commit : a757f6ec69794ab39a3d7f3e18d718bc861252f9 Date : Thu Sep 21 23:22:44 2017 Subject: GLHelper: Reusable fixed-ratio scaling and YUV-readback pipelines. Bisect Details Configuration: mac_retina_perf_bisect Benchmark : performance_browser_tests Metric : CastV2Performance_gpu_30fps_fast/total_latency Change : 1.78% | 26.6598451667 -> 27.1334518333 Revision Result N chromium@503520 26.6598 +- 0.383975 6 good chromium@503569 26.7155 +- 0.298375 6 good chromium@503593 26.7363 +- 0.553344 9 good chromium@503605 26.5791 +- 0.106534 6 good chromium@503607 26.7184 +- 0.226695 6 good chromium@503608 27.1629 +- 0.290749 6 bad <-- chromium@503611 27.1568 +- 0.398074 6 bad chromium@503617 27.1335 +- 0.261116 6 bad To Run This Test ./src/out/Release/performance_browser_tests --test-launcher-print-test-stdio=always --enable-gpu More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8967482512088277568 For feedback, file a bug with component Speed>Bisection
,
Sep 25 2017
Hmm...Interesting that it only regressed on Mac. FWIW, a lot of things are moving around under the umbrella of a rather large project. It's likely the new "arrangement," at project completion, will result in overall improved performance. Given the the regression is only 1ms of latency, and it's unlikely this will translate into any kind of user-perceivable regression, I'd like to wait on this and revisit later to see if it remains an issue. Marking this bug as blocked on bug 754872 .
,
Jan 5 2018
,
Jan 25 2018
,
Jan 26 2018
,
Feb 1 2018
,
Feb 7 2018
,
Feb 7 2018
,
Dec 18
Later work improved performance. Closing/Obsolete. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 25 2017