Big tables is print not correct
Reported by
speara...@gmail.com,
Sep 25 2017
|
|||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:55.0) Gecko/20100101 Firefox/55.0 Steps to reproduce the problem: 1. run html file What is the expected behavior? What went wrong? In print dialogue border of TDs is jumped in different places. Parts of borders cross text inside own cells. Screenshort #1. Export in PDF do the same. Screenshort #2 Did this work before? N/A Does this work in other browsers? Yes Chrome version: Version 61.0.3163.91 (Official Build) (64-bit) Channel: n/a OS Version: OS X 10.12 Flash Version: Shockwave Flash 27.0 r0
,
Sep 25 2017
This should be triaged by the Blink side, as printing code does not control table layout.
,
Sep 25 2017
,
Sep 27 2017
Over to dgrogan for table triage.
,
Sep 27 2017
,
Sep 28 2017
Not sure this is a regression though.
,
Sep 28 2017
Me neither, but the TE team will figure that out pretty quickly
,
Sep 28 2017
Able to Reproduce the issue on the reported chrome version stable 61.0.3163.91 latest canary 63.0.3226.0 on Windows 10 and Ubuntu 14.04. Issue is not reproducible on Mac 10.12.6. Issue is seen from M56 (56.0.2905.0) which has insignificant growth in the distortion of the alignment of text/lines. Issue is inconsistent on chrome versions prior to that, to provide the reliable bisect result . Hence triaging this as non-regression issue. Attaching the screencast for reference. Thank you!
,
Sep 28 2017
,
Sep 30 2017
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/818f2935aba99b00716f8ab2804c211d99c39f31 commit 818f2935aba99b00716f8ab2804c211d99c39f31 Author: Robert Hogan <robhogan@gmail.com> Date: Tue Oct 03 23:19:19 2017 Don't let intrinsic padding skew pagination struts on table cells Bug: 768330 Change-Id: Ic2ef22bbd3a533505c0cc4757b3758c6063cb35c Reviewed-on: https://chromium-review.googlesource.com/693881 Reviewed-by: Morten Stenshorne <mstensho@opera.com> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#506225} [add] https://crrev.com/818f2935aba99b00716f8ab2804c211d99c39f31/third_party/WebKit/LayoutTests/fragmentation/table-cell-intrinsic-padding-pagination-strut-expected.html [add] https://crrev.com/818f2935aba99b00716f8ab2804c211d99c39f31/third_party/WebKit/LayoutTests/fragmentation/table-cell-intrinsic-padding-pagination-strut.html [modify] https://crrev.com/818f2935aba99b00716f8ab2804c211d99c39f31/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c43a08fc7d2b3a2e3fb8ead1dcfc931ec3b5cd41 commit c43a08fc7d2b3a2e3fb8ead1dcfc931ec3b5cd41 Author: David Grogan <dgrogan@chromium.org> Date: Fri Oct 27 22:36:17 2017 Revert "Don't let intrinsic padding skew pagination struts on table cells" This reverts commit 818f2935aba99b00716f8ab2804c211d99c39f31. Reason for revert: See https://crbug.com/778682 (br + a in table cell is not correctly positioned) Original change's description: > Don't let intrinsic padding skew pagination struts on table cells > > Bug: 768330 > Change-Id: Ic2ef22bbd3a533505c0cc4757b3758c6063cb35c > Reviewed-on: https://chromium-review.googlesource.com/693881 > Reviewed-by: Morten Stenshorne <mstensho@opera.com> > Commit-Queue: Robert Hogan <robhogan@gmail.com> > Cr-Commit-Position: refs/heads/master@{#506225} TBR=mstensho@opera.com,robhogan@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768330 Change-Id: I4db77e4b4c8c41e1b3a417ed016525d6707df848 Reviewed-on: https://chromium-review.googlesource.com/742362 Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#512330} [delete] https://crrev.com/f69f536937fde81747ccfc01a08857e63b8be641/third_party/WebKit/LayoutTests/fragmentation/table-cell-intrinsic-padding-pagination-strut-expected.html [delete] https://crrev.com/f69f536937fde81747ccfc01a08857e63b8be641/third_party/WebKit/LayoutTests/fragmentation/table-cell-intrinsic-padding-pagination-strut.html [modify] https://crrev.com/c43a08fc7d2b3a2e3fb8ead1dcfc931ec3b5cd41/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
,
Oct 30 2017
Re-Tested this issue again on Windows 7 and Ubuntu 14.04 on 64.0.3253.0 Chrome version by following the steps mentioned in the original comment and can observe that alignment of the lines/text is correct in the print preview page. Attaches is the screen cast for reference. Hence adding TE Verified labels . Thanks...
,
Oct 30 2017
On OS X 10.11.6 Chrome version Version 62.0.3202.75 (Official Build) (64-bit) all good
,
Oct 30 2017
To comment 13: This is broken for me in Version 64.0.3253.0 (Official Build) canary (64-bit) on mac 10.12.6. See screenshot. Could you test on mac? The history of this bug is weird: - OP saw bug on mac - Comment 8 says only repro on linux/win, NOT mac - fix was put in - fix was reverted - comment 13 says NO repro on linux/win - I can repro on mac
,
Oct 30 2017
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0c99569dec48d1e980455d7893f4da03d780c04 commit c0c99569dec48d1e980455d7893f4da03d780c04 Author: David Grogan <dgrogan@chromium.org> Date: Mon Oct 30 23:26:55 2017 Revert "Don't let intrinsic padding skew pagination struts on table cells" This reverts commit 818f2935aba99b00716f8ab2804c211d99c39f31. Reason for revert: See https://crbug.com/778682 (br + a in table cell is not correctly positioned) Original change's description: > Don't let intrinsic padding skew pagination struts on table cells > > Bug: 768330 > Change-Id: Ic2ef22bbd3a533505c0cc4757b3758c6063cb35c > Reviewed-on: https://chromium-review.googlesource.com/693881 > Reviewed-by: Morten Stenshorne <mstensho@opera.com> > Commit-Queue: Robert Hogan <robhogan@gmail.com> > Cr-Commit-Position: refs/heads/master@{#506225} TBR=mstensho@opera.com,robhogan@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768330 Change-Id: I4db77e4b4c8c41e1b3a417ed016525d6707df848 Reviewed-on: https://chromium-review.googlesource.com/742362 Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#512330}(cherry picked from commit c43a08fc7d2b3a2e3fb8ead1dcfc931ec3b5cd41) Reviewed-on: https://chromium-review.googlesource.com/745062 Cr-Commit-Position: refs/branch-heads/3239@{#307} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [delete] https://crrev.com/3dc82198565ad5a5337df0e08cdcde651009705f/third_party/WebKit/LayoutTests/fragmentation/table-cell-intrinsic-padding-pagination-strut-expected.html [delete] https://crrev.com/3dc82198565ad5a5337df0e08cdcde651009705f/third_party/WebKit/LayoutTests/fragmentation/table-cell-intrinsic-padding-pagination-strut.html [modify] https://crrev.com/c0c99569dec48d1e980455d7893f4da03d780c04/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
,
Nov 1 2017
Tested this issue on Windows 7, Mac OS 10.12.6 and Ubuntu 14.04 using Chrome version 63.0.3239.30 and cann see the issue on Mac OS and Ubuntu 14.04 by following the steps mentioned in the original comment. Note: Issue is not observed on Windows 7 on the chrome version 63.0.3239.30. Attached are the screen shot and screen cast for reference. dgrogan@ Can you please check and update on this. Thanks..
,
Nov 2 2017
(clarifying repost of 19) I meant to request you check 64 canary. But, whatever, the history of the sporadic reproduction indicates that some users can reproduce and others can't; retesting won't add much signal. Luckily robhogan was able to reproduce and hopefully picks this up again.
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eacb4f4eb2e61cc6febe80fe23eb44eba2bde8e8 commit eacb4f4eb2e61cc6febe80fe23eb44eba2bde8e8 Author: Robert Hogan <robhogan@gmail.com> Date: Wed Nov 08 04:47:13 2017 Don't let intrinsic padding skew pagination struts on table cells Another go at resolving this bug, following on from https://chromium-review.googlesource.com/693881. This time we only clear the intrinsic padding on a cell during row layout if we plan to layout the children in the cell. Bug: 768330 Change-Id: Ia74f24f49b192e68a2dcb8cb5587470712543896 Reviewed-on: https://chromium-review.googlesource.com/753481 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#514748} [add] https://crrev.com/eacb4f4eb2e61cc6febe80fe23eb44eba2bde8e8/third_party/WebKit/LayoutTests/fast/table/intrinsic-padding-when-cell-child-doesnt-layout-expected.html [add] https://crrev.com/eacb4f4eb2e61cc6febe80fe23eb44eba2bde8e8/third_party/WebKit/LayoutTests/fast/table/intrinsic-padding-when-cell-child-doesnt-layout.html [add] https://crrev.com/eacb4f4eb2e61cc6febe80fe23eb44eba2bde8e8/third_party/WebKit/LayoutTests/fragmentation/table-cell-intrinsic-padding-pagination-strut-expected.html [add] https://crrev.com/eacb4f4eb2e61cc6febe80fe23eb44eba2bde8e8/third_party/WebKit/LayoutTests/fragmentation/table-cell-intrinsic-padding-pagination-strut.html [modify] https://crrev.com/eacb4f4eb2e61cc6febe80fe23eb44eba2bde8e8/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
,
Nov 8
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 10
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by ligim...@chromium.org
, Sep 25 2017