New issue
Advanced search Search tips

Issue 768305 link

Starred by 1 user
Status: Fixed
Owner:
ljusten@chromium.org
Closed: Sep 2017
Cc:
pastarmovj@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The doc writer should output correct XML in Mac examples

Project Member Reported by pastarmovj@chromium.org, Sep 25 2017 
Currently the strings of examples are verbatim written to the output text and
thus can contain invalid characters. 

for example here https://www.chromium.org/administrators/policy-list-3#RegisteredProtocolHandlers there is an ampersand in the sample string which should have been escaped to & in the plist code.

Comment 1 by ljusten@chromium.org, Sep 26 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06ed7efbb6a94ce8019f269a90dba3124c7d730c

commit 06ed7efbb6a94ce8019f269a90dba3124c7d730c
Author: Lutz Justen <ljusten@chromium.org>
Date: Tue Sep 26 18:16:38 2017

doc_writer.py: Escape special characters in Mac output

Example needs to be double escaped. & should be &amp;.

BUG= chromium:768305 
TEST=Loaded in Chrome, Mac & is escaped properly

Change-Id: I7fc2709b2ef230488a09b4289d06735e7d8fbddb
Reviewed-on: https://chromium-review.googlesource.com/685074
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504425}
[modify] https://crrev.com/06ed7efbb6a94ce8019f269a90dba3124c7d730c/components/policy/tools/template_writers/writers/doc_writer.py

Comment 3 by ljusten@chromium.org, Sep 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment