New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768297 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 26 days ago
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 768281



Sign in to add a comment

Can't stop dptf upstart job

Project Member Reported by pihsun@chromium.org, Sep 25 2017

Issue description

ChromeOS Test Image Version: 9971.0.0

What steps will reproduce the problem?
(1) Install a fresh new 9971.0.0 test image.
(2) "stop dptf"

What is the expected result?
The dptf job should be stopped.

What happens instead?
Command is stuck and doesn't complete.

The result of "status dptf" shows that upstart is tracking the wrong pid.
 

Comment 1 by pihsun@chromium.org, Sep 25 2017

Blocking: 768281
Cc: -pgeorgi@chromium.org
Owner: pgeorgi@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/684188 fixes the issue for me

Comment 4 by hungte@chromium.org, Sep 26 2017

Labels: OS-Chrome
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/12880aa5aa4d4266b61bec0a5a199c555d7b6bc6

commit 12880aa5aa4d4266b61bec0a5a199c555d7b6bc6
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Sep 26 18:15:53 2017

sys-power/dptf: Fix upstart configuration

"expect fork" doesn't work properly with scripted (or through-shell)
invocation of the daemon. Instead keep esif_ufd in foreground (-n) and
let upstart track that process (which is upstart's preferred approach
anyway).

BUG= chromium:768297 
BRANCH=none
TEST=Boot Chrome OS, check that `status dptf` returns the PID of the
esif_ufd process, that `stop dptf` works, and that `start dptf` returns
the correct PID of the newly started process.

Change-Id: Ic1743e15af15ab07916435e1da9e1a4ce562513a
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/684188
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>

[modify] https://crrev.com/12880aa5aa4d4266b61bec0a5a199c555d7b6bc6/sys-power/dptf/files/dptf.conf
[rename] https://crrev.com/12880aa5aa4d4266b61bec0a5a199c555d7b6bc6/sys-power/dptf/dptf-8.4.10100-r5.ebuild

Status: Fixed (was: Started)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment