New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 768289 link

Starred by 1 user
Status: Duplicate
Merged: issue 768063
Owner:
u...@chromium.org
Closed: Sep 2017
Cc:
mlippautz@chromium.org
█ hpayer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.4%-289.2% regression in v8.browsing_desktop at 503351:503862

Project Member Reported by mlippautz@chromium.org, Sep 25 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Sep 25 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=768289

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=a44c3db972ac8c4abd42ac0aa69ae0724cd28dbe709fc10c01830cb5c1daf19b


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-air
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-mac12-mini-8gb
chromium-rel-win10
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
linux-release
win-high-dpi
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Sep 29 2017 

📍 Pinpoint job completed.
https://pinpoint-dot-chromeperf.appspot.com/job/12ac7752780000

Found significant differences after 1 commit:

Reland "[heap] Enable concurrent marking for x86 and x64."
By ulan@chromium.org · Thu Sep 21 12:35:10 2017
v8@a76d0a771e430dbc8716624febc549aede738d96

Comment 5 by mlippautz@chromium.org, Sep 29 2017

Components: Blink>JavaScript>GC
Owner: u...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Sep 29 2017

Mergedinto: 768063
Status: Duplicate (was: Assigned)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Ulan Degenbaev
  Commit : a76d0a771e430dbc8716624febc549aede738d96
  Date   : Thu Sep 21 12:35:10 2017
  Subject: Reland "[heap] Enable concurrent marking for x86 and x64."

Bisect Details
  Configuration: linux_perf_bisect
  Benchmark    : v8.browsing_desktop
  Metric       : v8-gc-total_avg/browse_news/browse_news_nytimes
  Change       : 64.39% | 1.12177014984 -> 1.84405534969

Revision                           Result                   N
chromium@503432                    1.12177 +- 0.277431      6      good
chromium@503474                    1.09328 +- 0.50539       6      good
chromium@503485                    1.08829 +- 0.38026       6      good
chromium@503490                    1.10433 +- 0.362545      6      good
chromium@503491                    1.10433 +- 0.104228      6      good
chromium@503491,v8@2857dab5cb      1.08719 +- 0.52049       6      good
chromium@503491,v8@a76d0a771e      2.19775 +- 1.19776       6      bad       <--
chromium@503492                    2.08305 +- 0.841671      6      bad
chromium@503493                    1.97272 +- 0.766779      6      bad
chromium@503495                    2.16275 +- 0.624826      6      bad
chromium@503516                    1.84406 +- 0.623768      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.nytimes v8.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8967132853475758272


For feedback, file a bug with component Speed>Bisection
►

Sign in to add a comment