New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 768285 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Oct 2017
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

desktop-pwas: Icons should not be scraped from the page <link rel>s if any exist in a manifest

Project Member Reported by calamity@chromium.org, Sep 25 2017 
Currently we take all icons from a webpage, including the manifest icons and the <link rel> icons. Although manifest icons overwrite <link rel> icons, the manifest should be a full declaration of used icons, and we shouldn't use any other icons if the manifest exists.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07f7db8c5961ad7f839363951959f72dfd1a23c4

commit 07f7db8c5961ad7f839363951959f72dfd1a23c4
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Oct 03 02:50:55 2017

[desktop-pwas] Stop adding page favicons to bookmark apps with manifests.

This CL stops the BookmarkAppHelper from loading favicon.ico files into
bookmark apps if the apps have a manifest since the manifest should have
exact control over what icons the bookmark app uses.

Bug:  768285 
Change-Id: Ia89ace42a70d40b7134d6ec09c86bfe2a6f25bcb
Reviewed-on: https://chromium-review.googlesource.com/683855
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505933}
[modify] https://crrev.com/07f7db8c5961ad7f839363951959f72dfd1a23c4/chrome/browser/extensions/bookmark_app_helper.cc

Comment 2 by calamity@chromium.org, Oct 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment