New issue
Advanced search Search tips

Issue 768274 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task

Blocking:
issue 768828



Sign in to add a comment

Move Source/devtools/devtools-node-modules out from third_party/WebKit beforehand

Project Member Reported by tkent@chromium.org, Sep 25 2017

Issue description

Chrome Version: ToT
OS: Linux

What steps will reproduce the problem?
*** Do not try this. The following steps will break local repository. ***
(1) ./third_party/blink/tools/move_blink_source.py update --run
(2) ./third_party/blink/tools/move_blink_source.py move --git
(3) gclient sync
(4) Look at .git/config

What is the expected result?
[remote "origin"] section contains:
	url = https://chromium.googlesource.com/chromium/src.git

What happens instead?
[remote "origin"] section contains:
	url = https://chromium.googlesource.com/external/github.com/ChromeDevTools/devtools-noe-modules

Please use labels and text to provide additional information.
Not only .git/config. I observed some other repository corruption.

 

Comment 1 by tkent@chromium.org, Sep 25 2017

Owner: tkent@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28701026feb9bc381531914db4277d9902a4bfc4

commit 28701026feb9bc381531914db4277d9902a4bfc4
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Sep 25 23:51:09 2017

DevTools: Move devtools-node-modules checkout from //third_party/WebKit/Source/devtools/ to //third_party/

Checkout inside WebKit/Source is troublesome on the Great Blink mv.

Bug:  768274 
Change-Id: Ia57f3df4fad83dae56dd7d4cd9bef1841dae1a8c
Reviewed-on: https://chromium-review.googlesource.com/680180
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504217}
[modify] https://crrev.com/28701026feb9bc381531914db4277d9902a4bfc4/DEPS
[modify] https://crrev.com/28701026feb9bc381531914db4277d9902a4bfc4/third_party/.gitignore
[modify] https://crrev.com/28701026feb9bc381531914db4277d9902a4bfc4/third_party/WebKit/Source/devtools/.gitignore
[modify] https://crrev.com/28701026feb9bc381531914db4277d9902a4bfc4/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/28701026feb9bc381531914db4277d9902a4bfc4/third_party/WebKit/Source/devtools/scripts/buildbot/run_eslint.py

Comment 3 by tkent@chromium.org, Sep 25 2017

Status: Fixed (was: Started)

Comment 4 by tkent@chromium.org, Sep 26 2017

Blocking: -622551 768828

Sign in to add a comment