New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768259 link

Starred by 25 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[MD Bookmarks] Bookmark URL not easily viewable (eg. on hover)

Project Member Reported by calamity@chromium.org, Sep 25 2017

Issue description

From  Issue 658980 :

"Any chance the actual bookmark url can be always visible?

It's hidden under a hover in 61, but in the latest canary, you can only find out a bookmark's url by clicking edit? 

With the advent of tiny tabs, often urls are more meaningful than page titles"

==========

We could look into making the URLs appear on hover or on selection in the remaining whitespace in a bookmark row. Any thoughts?
 
Cc: zac.spit...@gmail.com
Google still shows urls in SERPS, i just think they should always be visible

Comment 3 by dhw@chromium.org, Dec 8 2017

Cc: tsergeant@chromium.org dpa...@chromium.org dbeam@chromium.org
 Issue 793275  has been merged into this issue.

Comment 4 by dhw@chromium.org, Dec 8 2017

Labels: -Type-Bug OS-Chrome OS-Linux OS-Mac OS-Windows Type-Bug-Regression
Summary: [MD Bookmarks] Bookmark URL not easily viewable (eg. on hover) (was: [MD Bookmarks] Bookmark URL not easily viewable)
I'm calling this a Regression, as it did work fine in the previous bookmark manager.

Comment 5 by nev...@gmail.com, Dec 27 2017

I think the URL should be always visible, and not just displayed on hover. I often look at URLs when organizing my 19k bookmarks (especially when trying to reduce the amount)...

As an example, I sometimes end up with a bookmark A (http://foo.com/bar) and a bookmark B (https://foo.com/bar) and with the old bookmark manager I could see at a quick glance that the only difference was the protocol, and I would remove the old "http" one.

If you think visible URLs are only useful for "power users", add this as an option. But I think they are useful for everybody.

Comment 6 by nole...@gmail.com, Dec 31 2017

I depend on url address in BMM to distinguish between versions of web pages.  Titles don't work unless each one from same source is edited by me to make visible something in the URL that identifies what it is, e.g. New York Times and its numerous versions use same names but different urls.
Cc: -calamity@chromium.org bettes@chromium.org
Owner: calamity@chromium.org
Status: Started (was: Untriaged)
The URL will be shown for selected and focused items. Tooltips have been added for elided titles and urls.
1OWEAvU9n1U.png
85.4 KB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52f251c9b58eb7d614923484ec73b192dc446be5

commit 52f251c9b58eb7d614923484ec73b192dc446be5
Author: Christopher Lam <calamity@chromium.org>
Date: Thu Jan 04 07:59:07 2018

[MD Bookmarks] Show URL on selected and focused items.

This CL shows the bookmark URL on selection and focus, and adds a tooltip
to elided titles and URLs. It also extracts an 'elided-text' class into
the shared styles.

Bug:  768259 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I985a24fb47f02b81d2cb10466df5e5ecb5608f8e
Reviewed-on: https://chromium-review.googlesource.com/846588
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526937}
[modify] https://crrev.com/52f251c9b58eb7d614923484ec73b192dc446be5/chrome/browser/resources/md_bookmarks/dnd_chip.html
[modify] https://crrev.com/52f251c9b58eb7d614923484ec73b192dc446be5/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/52f251c9b58eb7d614923484ec73b192dc446be5/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/52f251c9b58eb7d614923484ec73b192dc446be5/chrome/browser/resources/md_bookmarks/shared_style.html
[modify] https://crrev.com/52f251c9b58eb7d614923484ec73b192dc446be5/chrome/browser/resources/md_bookmarks/toast_manager.html

Labels: TE-Verified-M65 TE-Verified-65.0.3312.0
Tested this issue on Windows 7, Mac 10.12.6 & Ubuntu 14.04 using chrome-65.0.3312.0 as per C#0 & C#7.
Observed that URL's are displayed upon clicking each bookmark and also when bookmark get focussed (using tab).Tooltip displayed when we hover on any of the bookmark.As per the fix,issue working as intended.Hence adding TE Verified labels.

Please find the attached screencast for reference .
Thanks..!
768259.mp4
987 KB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c634aef7dc121750830d7d84a3e127e8cdfcaf7f

commit c634aef7dc121750830d7d84a3e127e8cdfcaf7f
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Jan 09 04:44:21 2018

[MD Bookmarks] Don't show URL on focus.

This CL removes showing the URL on focus, only showing it on selection.
This fixes an issue where mouse-down on a bookmark item showed the URL
which was disconcerting. Effectively, only keyboard focus will lose the
URL.

Bug:  768259 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3164545506aa6e560ce4ddd69bcfc751943bc0ec
Reviewed-on: https://chromium-review.googlesource.com/853713
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527902}
[modify] https://crrev.com/c634aef7dc121750830d7d84a3e127e8cdfcaf7f/chrome/browser/resources/md_bookmarks/item.html

Status: Verified (was: Started)
Labels: TE-Verified-65.0.3317.0
Tested this issue on Windows 7, Mac 10.12.6 & Ubuntu 14.04 using chrome-65.0.3317.0 as per C#0,C#7 & C#10.

Observations:
------------
1. URL's are displayed upon clicking each bookmark  
2. As per C#10 fix,URL's are not getting displayed when bookmark get focussed (using tab).
3. Tooltip displayed when we hover on any of the bookmark.

As issue working as intended adding TE Verified labels.

Please find the attached screencast for reference .
Thanks..!
768259.mp4
971 KB View Download
1. the tooltip repeats the bookmark title rather than the url?
2. sometimes bookmarks have no title, i.e for the bookmark bar, can the url be shown when there is no title?
1. This is working as intended, the tooltip is to help with extra long titles/urls.

2. I don't think this is going to happen. As a workaround, you can press Ctrl + A to see all URLs though?
http://212.118.128.147:50400/iphone/STC-EAP-iStewie.mobileconfig
STC-EAP-iStewie.mobileconfig
3.1 KB Download
السبت_٣١_مارس_٢٠١٨_٠١_٢٦_٠١_cloud_link.html
313 bytes View Download
Configuration.htm
29.6 KB View Download
porxy.ip45.60.58.21.com.txt
170 bytes View Download

Sign in to add a comment