New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768231 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-02-05
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Spell Check Underlining not working properly in large textboxes (Confluence)

Reported by martin.e...@googlemail.com, Sep 24 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36

Steps to reproduce the problem:
1. Write a document in confluence with some headings and paragraphs, that contain misspelled words
2. Save the page
3. Edit the page again
4. Look if misspelled words are underlined for the whole page without moving the cursor to the specific paragraph.

What is the expected behavior?
Spell-checker should underline misspelled words immediately after editing a textbox/field.

What went wrong?
Setting the cursor in the paragraph does not underline the misspelled word. It only gets underlined after "leaving" the specific paragraph. 

Did this work before? Yes Unknown, I guess a few months ago.

Chrome version: 60.0.3112.113  Channel: stable
OS Version: 10.0
Flash Version: 

I have been using the Google Chrome Spell Checking together with Atlassian Confluence for a long time. Recently the underlining of misspelled words has become very unreliable, especially for longer documents. I can reproduce the effect in Confluence documents with a medium amount of words (about 600 words). If I edit such a document in confluence, the whole text gets printed in a large textbox. Underlining in this textbox does not work properly - specifically I have to move the mouse cursor to a paragraph, and only after switching to another paragraph the words in the former paragraph get underlined.
Another way to reproduce the effect is to scroll through the whole textbox by cursor keys. Is there any way to fix this behaviour? I am very sure that this worked properly some months ago.

I am using the built-in spell checking toll for chrome (no 3rd party extension). The issue also occurs on the latest  canary build.

I have added a video to watch the issue: https://drive.google.com/open?id=0B2kyUwSOKJH5QXF4aDlUNm9ZWDg 

Another test I did with wordpress instead of confluence proofed that this is not a general problem but only occurs in combination of confluence and chrome, because in wordpress editing a large article immediately underlined all the misspelled words.
 
Labels: Needs-Bisect Needs-Milestone
Unable to reproduce the issue on reported version 60.0.3112.113 , Latest Stable 61.0.3163.100 and Latest Canary 63.0.3223.1 using Windows 10, Ubuntu 14.04 with the below mentioned steps.

1.Written a document with some headings and paragraphs, which has miss spelled words.
2.saved the page
3.Edited the page again
4.I observed that a wrongly spelt word is shown with underline without the cursor being moved to another paragraph.

@Reporter: could you please attach a sample document in which you are facing the issue, so that we can check particularly.

Thanks.


Cc: sc00335...@techmahindra.com vamshi.k...@techmahindra.com
Components: -UI Blink>Editing>Spellcheck
Labels: Triaged-ET Needs-Feedback
Hello,

a sample document is tricky, because like I mentioned this does occur when using Atlassian Confluence (a CMS). Like shown in the video, my sample document had several headings and several paragraphs with "lorem ipsum" text. That was enough for me to reproduce the issue. Did you try to reproduce with Confluence or with any other website with textboxes?

Best wishes,
Martin
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 25 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "sc00335628@techmahindra.com" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Follow-Up:
I just checked with a local installation of confluence at my home PC, and the issue does occur here too. I attached the content of the used Confluence page here.

Best wishes,
Martin
Test.odt
23.7 KB Download
Cc: -sc00335...@techmahindra.com -vamshi.k...@techmahindra.com divya.pa...@techmahindra.com
Labels: Needs-Feedback
@Reporter: We have tried downloading confluence from https://confluence.atlassian.com/conf56/installing-confluence-on-linux-658737324.html,but we are unable to launch it. Could you please help us in launching it so that we can check the issue with the document provided.

Thanks!
Hello,

I am very sorry, but I only did an installation on Windows. I can not provide assistance for installing on linux. Maybe you could try with a free trial of a on demand version - https://de.atlassian.com/software/confluence/try

Best wishes,
Martin
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 27 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "divya.padigela@techmahindra.com" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by woxxom@gmail.com, Sep 27 2017

Reporter, maybe you can bisect the bug yourself?
The instruction: https://www.chromium.org/developers/bisect-builds-py
Basically, you download the script, install python, run the script command line using revision numbers from chrome://version page e.g. -a win -g 400000 -b 500000
When done, double- or even triple-check the result by running the bisect script again with the found revision numbers and --verify-range
Labels: -Needs-Bisect Needs-Feedback
Downloaded the free trial of confluence as per the link provided in C#8 and able to reproduce this issue on reported vaersion 60.0.3112.113 , But fixed on latest stable 61.0.3169.100 and on latest canary 63.0.3226.0 using Ubuntu 14.04,Mac 10.12.6 and Windows 10 with steps mentioned in comment#8. Attaching screencast for reference.

@Reporter: Could you upgrade chrome to latest stable and check whether this issue reproduces from your end or not? You can download latest stable from https://www.chromium.org/getting-involved/dev-channel.
Issue 768231.mp4
1.4 MB View Download
Hello,

I can confirm that with the latest build, the words get underlined directly after moving the cursor to the paragraph, just as shown in your screencast. But the expected behavior for me would be, that after switching to edit mode, all the words in the textbox get underlined (in wordpress this behavior is working correctly). It really is annoying if I work on a large document, and want to fix the typos before finishing it - I have to place the cursor over every single paragraph to get all underlinings to work.

Best wishes,
Martin
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 28 2017

Cc: sc00335...@techmahindra.com
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "sc00335628@techmahindra.com" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
#12: Thanks for the feedback.

Spellchecking can be expensive on large documents. That's why our current strategy is to check only a snippet around the selection, which means trading completeness for performance.

We'll consider changing the strategy if it doesn't regress the overall experience.
Status: Available (was: Unconfirmed)
We may want to have cold mode spell checker which scan document from start to end
in addition to hot mode spell checker which scan around where user is working on.
Labels: -Type-Bug-Regression Type-Bug
Removing the regression tag as of #12

Comment 17 by jones...@gmail.com, Nov 22 2017

I've found this bug is happening for me on Version 62.0.3202.94 (Official Build) (64-bit).

It seems to still happen on complex documents with tables. 
If I spam a document with a sentence with a misspelt word, Chrome will pick it up as soon as I put my mouse cursor on it.

But when I have a properly large document, it still fails: http://recordit.co/xVjeo89aFG

In the above, I take a section off the GitHub Security page (for lack of a better properly formatted document), and then paste it into a blank confluence document 5 times. 

The first four times Chrome marks "plaintext" as a spelling mistake. I actually manage to paste it so fast the Chrome doesn't check pastes two and three, but if I click on the word, it does get marked as misspelled as expected. 

However the text after the fourth paste (i.e the fifth paste) is completely ignored.

I've tried clearing my cache, logging in and out, etc etc. 

I've not yet tried it in Canary, but may do so tonight. 

I can also verify the bug in complex confluence documents with various makros like info, note or warning panels as well as different headings.
I've just encountered this bug today with lack of spell check in Confluence, as well, with almost exactly the same behaviors.  Two additional notes of particular interest to me that I didn't see mentioned yet:

1) While *writing* a large document, I'm not getting active spell check while continuing to type.  Even in the case where spellcheck on the whole document is expensive, I'd hope that I'd see the red underline for words I've just misspelled as I type them and then continue typing on the same line.

2) It appears that in some cases (page too long, or having passed a table or macro or something in the middle, perhaps?), I can't trigger the spell checker to go back even by clicking on a paragraph or by cursor scrolling through the page - past a certain threshold, spell check just dies and I get no visual indication of obviously misspelled words past that point no matter how I try to focus the cursor.

Windows 10 / Chrome Stable Version 62.0.3202.94 (Official Build) (64-bit)
NextAction: 2017-12-11
I'll do some tweaking with spellchecker in mid Dec.
The NextAction date has arrived: 2017-12-11

Comment 22 by yosin@chromium.org, Jan 10 2018

Labels: Pri-3
Any update on this I still have the issue at 63.0.3239.132 (Official Build) (64-bit)
NextAction: 2018-02-05
Sorry, I planned but didn't have time to investigate in last Dec. I'll take another try in the week of Feb 5.

In the meantime, it's more than welcome if anyone is interested in taking this issue :)

Comment 25 by le...@matic.com, Feb 3 2018

I can confirm this bug. We use Confluence Cloud and multiple people in the company have noticed that Chrome spellcheck stops underlining misspelled words on long pages or pages with tables or macros. 

Checked in FireFox and issues is not present, which leads us to believe it is a chrome issue. 

We would greatly appreciate a fix! Thank your for your help!!!
The NextAction date has arrived: 2018-02-05
Owner: xiaoche...@chromium.org
Status: Started (was: Available)
Got it.

Blink spellchecker uses a heuristic that, if an editing host is not in the viewport, don't check anything in it.

However, in Confluence, the editing host is the BODY element that has "height: 100%" style, fixing its height equal to viewport height regardless of the content in it.

Hence, when editing a long document with height > 2x viewport height, the BODY element is completely out of viewport, and hence, not checked.

Conclusion: the heuristic is wrong and should be removed.
>#c27, I'm not sure about reasoning. 

Why Element::VisibleBoundsInVisualViewport() for
<body contenteditable style="height:100%">
returns empty rect?

Weird, I can't reproduce with the same test case on my Mac laptop...

Anyway, here's a pretty similar repro: https://jsfiddle.net/2g02xpms/

Scroll to bottom and observe that the box of BODY is out of viewport, due to its fixed height. Since it's out of viewport, Element::VisibleBoundsInVisualViewport() returns empty.

Since CSS allows an element to be outside its ancestor's box, the heuristic is wrong and should be removed.
Project Member

Comment 30 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a91c371d6174dc43596791212beb23bbcfabc151

commit a91c371d6174dc43596791212beb23bbcfabc151
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Wed Feb 07 00:19:13 2018

Remove an incorrect heuristic from spellchecker

Spellchecker has a heuristic that, if the bounding box of an editing host
is not in viewport, don't check anything in the editing host.

This is wrong as there might still be descendants of the editing host
inside the viewport. Hence, this patch removes the heuristic.

Bug:  768231 
Change-Id: I22995b365c6a3e10eedb76a4868746f09261e733
Reviewed-on: https://chromium-review.googlesource.com/903265
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534848}
[add] https://crrev.com/a91c371d6174dc43596791212beb23bbcfabc151/third_party/WebKit/LayoutTests/editing/spelling/editing_host_out_of_viewport.html
[modify] https://crrev.com/a91c371d6174dc43596791212beb23bbcfabc151/third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp

Status: Fixed (was: Started)
Fixed in M66. The stable release will be around mid April.

Comment 32 by fmil...@sofi.org, Apr 11 2018

How can I get latest canary build (66) where Confluence spell checker is working again?
Hello,

any update on the date of the stable release?

Best wishes,
Martin

Comment 35 by woxxom@gmail.com, Apr 25 2018

Chrome 66 was released to the stable channel 7 days ago on Apr, 17.

Sign in to add a comment