New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 768229 link

Starred by 1 user
Status: Verified
Owner:
█ emso@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
tkent@chromium.org
j...@chromium.org
flyboy@chromium.org
rauch+monorail-auto@google.com
█ orodley+autocc@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 768878


Sign in to add a comment

Generated files are not updated for 11+ days

Project Member Reported by pdr@chromium.org, Sep 24 2017 
https://cs.chromium.org/chromium/src/out/Debug/gen/blink/platform/RuntimeEnabledFeatures.h has the following comment at the top:
// Generated from template:
//   templates/RuntimeEnabledFeatures.h.tmpl
// and input files:
//   ../../third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

RuntimeEnabledFeatures.json5 has been renamed runtime_enabled_features.json5. I think we just need to plumb the correct filename down into the generator instead of using the class name. This bug seems to affect other template-based code generators too (e.g., FontFamilyNames).

Comment 1 by tkent@chromium.org, Sep 24 2017

Cc: tkent@chromium.org
Components: -Blink>Bindings Infra>Codesearch
Owner: ----
Status: Untriaged (was: Assigned)
Summary: Generated files are not updated for 11+ days (was: RuntimeEnabledFeatures.h says it is generated by non-existant RuntimeEnabledFeatures.json5)
We generate runtime_enabled_features.h, not RuntimeEnabledFeatures.h, since 11 days ago, and runtime_enabled_features.h has the correct json5 file name.
It seems Code search doesn't index runtime_enabled_features.h yet.

Comment 2 by emso@chromium.org, Sep 25 2017

Owner: emso@chromium.org
Status: Started (was: Untriaged)

Comment 3 by emso@chromium.org, Sep 25 2017 

I see the sought file in the underlying generated files repo: https://chromium.googlesource.com/chromium/src/out/+/master/Debug/gen/blink/platform. The builder generating files and uploading looks green. 

The old generated file also shows up the repo and it should probably not be there, but this is a separate issue.

Comment 4 by emso@chromium.org, Sep 25 2017 

The old files are due to a lack of clean up by the GEN bot Builder. On the machine, I can still see old generated files in the build dir of the Builder.

Comment 5 by emso@chromium.org, Sep 25 2017 

I see issues in the DEPS bot syncing dependencies, which includes the out directory for generated files.

Comment 6 by emso@chromium.org, Sep 25 2017

Labels: -Pri-2 Pri-1
The DEPS bot is failing when setting up it's chromium/src cache.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/0f09f97100cd600e525181584e7416432f524e52

commit 0f09f97100cd600e525181584e7416432f524e52
Author: Emma <emso@chromium.org>
Date: Mon Sep 25 11:36:28 2017

Adds progress argument option to fetch for git checkout

Bug:768229
Change-Id: If6988e3a75e66beb2900360b10d63560b4c0b345
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: skia
Recipe-Nontrivial-Roll: release_scripts
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/681194
Commit-Queue: Emma Söderberg <emso@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/cannot_fail_build.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/curl_trace_file.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/set_got_revision.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/count-objects_failed.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/basic_submodule_update_force.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/basic_file_name.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/count-objects_with_bad_output.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/basic_hash.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/git-cache-checkout.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/api.py
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/count-objects_delta.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/basic_branch.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/README.recipes.md
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/basic.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/basic_ref.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/can_fail_build.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/cat-file_test.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/remote_not_origin.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/count-objects_with_bad_output_fails_build.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/rebase_failed.json
[modify] https://crrev.com/0f09f97100cd600e525181584e7416432f524e52/recipes/recipe_modules/git/examples/full.expected/platform_win.json

Comment 9 by emso@chromium.org, Sep 26 2017 

The timeout issue has been resolved but there is an issue in the deps2submodule script.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0e8aa19db5239631024197ac4a0ac71b00b95c1e

commit 0e8aa19db5239631024197ac4a0ac71b00b95c1e
Author: Emma <emso@chromium.org>
Date: Tue Sep 26 12:16:29 2017

Adds extraction of URL for DEP with conditional

Bug:768229
Change-Id: I22d4fbdafbf7cf17d3b363e7e211d5cf5e277d5e
Reviewed-on: https://chromium-review.googlesource.com/684176
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Emma Söderberg <emso@chromium.org>

[modify] https://crrev.com/0e8aa19db5239631024197ac4a0ac71b00b95c1e/recipes/recipe_modules/sync_submodules/resources/deps2submodules.py

Comment 11 by pdr@chromium.org, Sep 26 2017

Blockedon: 768878

Comment 12 by emso@chromium.org, Sep 27 2017 

DEPS bot is green again and generated files are updated. Leaving bug open to track clean up of old generated files which are currently displayed in code search.
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/887d72463b29964c810ef270337db583e16197f0

commit 887d72463b29964c810ef270337db583e16197f0
Author: Emma Soederberg <emso@chromium.org>
Date: Wed Sep 27 10:18:32 2017

Adds cleanup of old generated files.

Old generated files left in src/out are automatically synced to
the GEN repo and displayed in code search.

Bug:768229
Change-Id: If0cd29a816d2c90d2b9c3446a048090707e85b98
Reviewed-on: https://chromium-review.googlesource.com/685656
Commit-Queue: Emma Söderberg <emso@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/887d72463b29964c810ef270337db583e16197f0/scripts/slave/recipe_modules/codesearch/api.py
[modify] https://crrev.com/887d72463b29964c810ef270337db583e16197f0/scripts/slave/recipe_modules/codesearch/examples/full.py
[modify] https://crrev.com/887d72463b29964c810ef270337db583e16197f0/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_android.json
[modify] https://crrev.com/887d72463b29964c810ef270337db583e16197f0/scripts/slave/recipes/chromium_codesearch.py
[modify] https://crrev.com/887d72463b29964c810ef270337db583e16197f0/scripts/slave/README.recipes.md
[modify] https://crrev.com/887d72463b29964c810ef270337db583e16197f0/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_fail.json
[modify] https://crrev.com/887d72463b29964c810ef270337db583e16197f0/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_webrtc_linux.json
[modify] https://crrev.com/887d72463b29964c810ef270337db583e16197f0/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux.json
[modify] https://crrev.com/887d72463b29964c810ef270337db583e16197f0/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos.json
[modify] https://crrev.com/887d72463b29964c810ef270337db583e16197f0/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_linux_test_basic.json

Comment 14 by tkent@chromium.org, Sep 27 2017 

runtime_enabled_features.h appeared, and RuntimeEnabledFeatures.h was gone.  Thanks you for the quick fix!

Comment 15 by emso@chromium.org, Sep 28 2017 

You're welcome! We are not entirely out of the woods yet because the added cleanup script is missing a flag (added in https://chromium-review.googlesource.com/c/chromium/tools/build/+/688235) causing it to fail on directories. Once that fix is in we should be good.
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a233f38804b239802933c444b9d3e18212dd58b9

commit a233f38804b239802933c444b9d3e18212dd58b9
Author: Emma Soederberg <emso@chromium.org>
Date: Thu Sep 28 06:22:11 2017

Adds missing files flag to cleanup

Bug:768229
Change-Id: I4ab9144cca78c8586d00e942afbcd0b524509abf
Reviewed-on: https://chromium-review.googlesource.com/688235
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Emma Söderberg <emso@chromium.org>

[modify] https://crrev.com/a233f38804b239802933c444b9d3e18212dd58b9/scripts/slave/recipe_modules/codesearch/api.py
[modify] https://crrev.com/a233f38804b239802933c444b9d3e18212dd58b9/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_fail.json
[modify] https://crrev.com/a233f38804b239802933c444b9d3e18212dd58b9/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_android.json
[modify] https://crrev.com/a233f38804b239802933c444b9d3e18212dd58b9/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_webrtc_linux.json
[modify] https://crrev.com/a233f38804b239802933c444b9d3e18212dd58b9/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux.json
[modify] https://crrev.com/a233f38804b239802933c444b9d3e18212dd58b9/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos.json
[modify] https://crrev.com/a233f38804b239802933c444b9d3e18212dd58b9/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_linux_test_basic.json

Comment 17 by emso@chromium.org, Sep 28 2017

Status: Verified (was: Started)
Final issue fixed.
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/55d54d3f33a51e0f3279e2beb6cd7bd962406be4

commit 55d54d3f33a51e0f3279e2beb6cd7bd962406be4
Author: Emma Soederberg <emso@chromium.org>
Date: Fri Sep 29 07:46:56 2017

Adds missing URL conversion for conditional DEPS

Bug:768229
Change-Id: Iac069e6680c85c1b520c70a67f9de73ce8794caa
Reviewed-on: https://chromium-review.googlesource.com/691716
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Emma Söderberg <emso@chromium.org>

[modify] https://crrev.com/55d54d3f33a51e0f3279e2beb6cd7bd962406be4/recipes/recipe_modules/sync_submodules/resources/deps2submodules.py
►

Sign in to add a comment